Closed
Bug 1321222
Opened 8 years ago
Closed 8 years ago
Remove legacy generator from js/xpconnect/.
Categories
(Core :: XPConnect, defect)
Core
XPConnect
Tracking
()
RESOLVED
FIXED
mozilla53
| Tracking | Status | |
|---|---|---|
| firefox53 | --- | fixed |
People
(Reporter: arai, Assigned: arai)
References
Details
Attachments
(1 file)
|
3.31 KB,
patch
|
mrbkap
:
review+
|
Details | Diff | Splinter Review |
Just replaced legacy generator with ES6 generator.
some notes:
* js/xpconnect/tests/chrome/test_bug853571.xul
ES6 generator doesn't throw StopIteration, but returns object with {done, value} properties
* js/xpconnect/tests/mochitest/test_bug505915.html
this test looks like modified many times and now it contains many obsolete parts
message shouldn't be received and |go| function just finishes the test before yielding.
so removed yield and generator handling, and also added assertion in message listener
Attachment #8815635 -
Flags: review?(mrbkap)
|
||
Updated•8 years ago
|
Attachment #8815635 -
Flags: review?(mrbkap) → review+
|
Assignee | |
Comment 1•8 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/5d5c575b4a262e56077f05ca8a6c596a0409c5ac
Bug 1321222 - Remove legacy generator from js/xpconnect/. r=mrbkap
|
||
Comment 2•8 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
You need to log in
before you can comment on or make changes to this bug.
Description
•