Closed Bug 1321222 Opened 3 years ago Closed 3 years ago

Remove legacy generator from js/xpconnect/.

Categories

(Core :: XPConnect, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla53
Tracking Status
firefox53 --- fixed

People

(Reporter: arai, Assigned: arai)

References

Details

Attachments

(1 file)

Just replaced legacy generator with ES6 generator.

some notes:

* js/xpconnect/tests/chrome/test_bug853571.xul
  ES6 generator doesn't throw StopIteration, but returns object with {done, value} properties

* js/xpconnect/tests/mochitest/test_bug505915.html
  this test looks like modified many times and now it contains many obsolete parts
  message shouldn't be received and |go| function just finishes the test before yielding.
  so removed yield and generator handling, and also added assertion in message listener
Attachment #8815635 - Flags: review?(mrbkap)
Attachment #8815635 - Flags: review?(mrbkap) → review+
https://hg.mozilla.org/mozilla-central/rev/5d5c575b4a26
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
You need to log in before you can comment on or make changes to this bug.