Closed Bug 1321231 Opened 5 years ago Closed 5 years ago

Correct WebRenderLayer coordinate

Categories

(Core :: Graphics: WebRender, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla54

People

(Reporter: ethlin, Assigned: ethlin)

References

Details

Attachments

(4 files, 1 obsolete file)

I tried some testcases and it looks like the overflow rect is wrong.
Attached file testcase1
Attached file testcase2
Attached patch correct overflow rect (obsolete) — Splinter Review
The overflow rect x/y should be zero or the image will be cut.
Blocks: webrender
Attachment #8815649 - Attachment is obsolete: true
Attachment #8815656 - Flags: review?(nical.bugzilla)
The canvas size is wrong on MacOS. I think we should apply transform for image rect before DoDPPushImage. I'll have another patch for it.
Attached patch apply transformSplinter Review
We should apply transform for image. The testcase1 can reproduce the problem on Mac.
Attachment #8815674 - Flags: review?(nical.bugzilla)
Attachment #8815656 - Flags: review?(nical.bugzilla) → review+
Pushed by mtseng@mozilla.com:
https://hg.mozilla.org/projects/graphics/rev/9470258a4c70
Fix the overflow rect of WebRenderLayer. r=nical
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Attachment #8815674 - Flags: review?(nical.bugzilla) → review+
Pushed by mtseng@mozilla.com:
https://hg.mozilla.org/projects/graphics/rev/02fdf5d71d8e
Apply transform for canvas rect. r=nical
Status: REOPENED → RESOLVED
Closed: 5 years ago5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
You need to log in before you can comment on or make changes to this bug.