Closed
Bug 1321231
Opened 9 years ago
Closed 9 years ago
Correct WebRenderLayer coordinate
Categories
(Core :: Graphics: WebRender, defect)
Core
Graphics: WebRender
Tracking
()
RESOLVED
FIXED
mozilla54
People
(Reporter: ethlin, Assigned: ethlin)
References
Details
Attachments
(4 files, 1 obsolete file)
|
605 bytes,
text/html
|
Details | |
|
511 bytes,
text/html
|
Details | |
|
4.04 KB,
patch
|
nical
:
review+
|
Details | Diff | Splinter Review |
|
1.20 KB,
patch
|
nical
:
review+
|
Details | Diff | Splinter Review |
I tried some testcases and it looks like the overflow rect is wrong.
|
Assignee | |
Comment 1•9 years ago
|
||
|
|
Assignee | |
Comment 2•9 years ago
|
||
|
|
Assignee | |
Comment 3•9 years ago
|
||
The overflow rect x/y should be zero or the image will be cut.
|
|
Assignee | |
Comment 4•9 years ago
|
||
Attachment #8815649 -
Attachment is obsolete: true
Attachment #8815656 -
Flags: review?(nical.bugzilla)
|
|
Assignee | |
Comment 5•9 years ago
|
||
The canvas size is wrong on MacOS. I think we should apply transform for image rect before DoDPPushImage. I'll have another patch for it.
|
|
Assignee | |
Comment 6•9 years ago
|
||
We should apply transform for image. The testcase1 can reproduce the problem on Mac.
Attachment #8815674 -
Flags: review?(nical.bugzilla)
|
||
Updated•9 years ago
|
Attachment #8815656 -
Flags: review?(nical.bugzilla) → review+
Pushed by mtseng@mozilla.com:
https://hg.mozilla.org/projects/graphics/rev/9470258a4c70
Fix the overflow rect of WebRenderLayer. r=nical
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
|
||
Updated•9 years ago
|
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
|
|
||
Updated•9 years ago
|
Attachment #8815674 -
Flags: review?(nical.bugzilla) → review+
Pushed by mtseng@mozilla.com:
https://hg.mozilla.org/projects/graphics/rev/02fdf5d71d8e
Apply transform for canvas rect. r=nical
Status: REOPENED → RESOLVED
Closed: 9 years ago → 9 years ago
Resolution: --- → FIXED
|
||
Updated•8 years ago
|
Target Milestone: --- → mozilla54
You need to log in
before you can comment on or make changes to this bug.
Description
•