1321245 - Crash when delayed keypress event is dispatched in e10s

Status: RESOLVED FIXED

(Core :: DOM: UI Events & Focus Handling, defect)

Description

[Jessica Jong [:jessica] (inactive)]

See bug 1316330 comment 24.

Hitting 'MOZ_ASSERT(mNativeKeyCommandsValid)' in PuppetWidget::ExecuteNativeKeyBinding.

Actually, the same issue was found in Bug 993714, but it was fixed only for synthetic events. By doing the same for delayed events solves the issue. I'll provide a patch and see if it's okay.

Comment 1

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Jessica, I know you are working on this, so assign to you. Thanks for taking this one.

Comment 2

[Jessica Jong [:jessica] (inactive)]

Attachment: patch, v1.

Hi Olli, this is for fixing the crash. If the native key bindings list is no longer available when the delayed event is dispatched, we request it again.

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8816007 [details] [diff] [review]
patch, v1.

So this gives a new meaning to mIsSuppressedOrDelayed. Atm it is set only for events which are suppressed or delayed so that later a new similar event is dispatched. But this sets the flag on those events which will be dispatched afterwards. At least document this new meaning in BasicEvents.h

Comment 4

[Jessica Jong [:jessica] (inactive)]

(In reply to Olli Pettay [:smaug] from comment #3)
> Comment on attachment 8816007 [details] [diff] [review]
> patch, v1.
> 
> So this gives a new meaning to mIsSuppressedOrDelayed. Atm it is set only
> for events which are suppressed or delayed so that later a new similar event
> is dispatched. But this sets the flag on those events which will be
> dispatched afterwards. At least document this new meaning in BasicEvents.h

Right, I will document this in BasicEvents.h. Thanks.

Comment 5

[Jessica Jong [:jessica] (inactive)]

Attachment: patch, v2.

Added more documentation for mIsSuppressedOrDelayed in BasicEvents.h. Carrying r+.

Comment 6

[Jessica Jong [:jessica] (inactive)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=065343694038fb04c3fa51223589206a0dcdbd07&group_state=expanded

Comment 7

[Carsten Book [:Tomcat]]

needs rebasing

applying bug-132145-crash-nativekeybindings.patch
unable to find 'layout/base/nsPresShell.cpp' for patching
(use '--prefix' to apply patch relative to the current directory)
1 out of 1 hunks FAILED -- saving rejects to file layout/base/nsPresShell.cpp.rej
patch failed, unable to continue (try -v)
patch failed, rejects left in working directory
errors during apply, please fix and qrefresh bug-132145-crash-nativekeybindings.patch

Comment 8

[Jessica Jong [:jessica] (inactive)]

Attachment: patch, v2 (rebased)

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d0055028cd1f
Request native key bindings for delayed keypress events. r=smaug

Comment 10

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/d0055028cd1f