Closed Bug 1321261 Opened 3 years ago Closed 3 years ago

Create dom/file for any cpp/h files related to File/Blob APIs (FileReader and FileList)

Categories

(Core :: DOM: Core & HTML, defect)

50 Branch
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla53
Tracking Status
firefox53 --- fixed

People

(Reporter: baku, Assigned: baku)

References

Details

Attachments

(1 file)

Attached patch file.patchSplinter Review
I always wanted to do this. I think it's much cleaner to have a separate folder for these APIs.
Attachment #8815691 - Flags: review?(kyle)
Comment on attachment 8815691 [details] [diff] [review]
file.patch

Review of attachment 8815691 [details] [diff] [review]:
-----------------------------------------------------------------

Yay cleanup!

::: dom/base/nsDOMNavigationTiming.cpp
@@ +14,5 @@
>  #include "nsIURI.h"
>  #include "nsPrintfCString.h"
>  #include "mozilla/dom/PerformanceNavigation.h"
>  #include "mozilla/TimeStamp.h"
> +#include "mozilla/Telemetry.h"

Nit: Not sure how this relates to the rest of the patch. Is this just some cleanup that ended up in here? It's fine since it's just namespace cleanup, just making sure it's supposed to be here.
Attachment #8815691 - Flags: review?(kyle) → review+
> Nit: Not sure how this relates to the rest of the patch. Is this just some

They are related. Often, when we move/create/delete files/directories, we change the unified blocks of cpp files and this shows the missing of header files, or namespaces and so on.

In this particular case, nsDOMNavigationTiming was using the Telemetry header from some other cpp file.
Backout by archaeopteryx@coole-files.de:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3245e69aa698
Backed out changeset 806c3d121dd4 for timing out in test_fileapi.html, test_mozfiledataurl.html and test_nonascii_blob_url.html on Linux x64 asan and debug. r=backout
Pushed by amarchesini@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/75cdb99537b5
create dom/file for File APIs - part 2, r=me
Backout 2 for build bustage (calling missing file BlobParent.h from dom/ipc/TabParent.cpp):

https://hg.mozilla.org/integration/mozilla-inbound/rev/29fd1259e299250eb26e4c83dbef8c55de612305
https://hg.mozilla.org/integration/mozilla-inbound/rev/961f1e72a7b5a04ac81f6b468c7b45daaabc7452

Latest push with failures: https://hg.mozilla.org/integration/mozilla-inbound/rev/75cdb99537b502b06be217a6501da2e898f8bda7
Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=40172439&repo=mozilla-inbound

/builds/slave/m-in-l64-000000000000000000000/build/src/dom/ipc/TabParent.cpp:44:24: fatal error: BlobParent.h: No such file or directory


Previous backout 1 for timing out in test_fileapi.html, test_mozfiledataurl.html and test_nonascii_blob_url.html on Linux x64 asan and debug:

https://hg.mozilla.org/integration/mozilla-inbound/rev/3245e69aa698265f4ff511fda5fccaa35b112f90

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=806c3d121dd45fa9af850d287f61d76e33dd08f1
Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=40161261&repo=mozilla-inbound

TEST-UNEXPECTED-FAIL | dom/file/tests/test_fileapi.html | Test timed out.
TEST-UNEXPECTED-FAIL | dom/file/tests/test_mozfiledataurl.html | Test timed out.
TEST-UNEXPECTED-FAIL | dom/file/tests/test_nonascii_blob_url.html | Test timed out.
Flags: needinfo?(amarchesini)
https://hg.mozilla.org/mozilla-central/rev/9ad9c6b4c8d6
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
Flags: needinfo?(amarchesini)
as a note, the num_constructors increased with this patch:
https://treeherder.mozilla.org/perf.html#/alerts?id=4417

while this isn't anything we have rules or expectations to backout, it is good information to have in case we did something accidentally.
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.