1321274 - Remove usage of javascript String generics

Status: RESOLVED FIXED

(MailNews Core :: Backend, defect)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

String generics are non-standard SpiderMonkey extension and they should be removed.
  * String.charAt
  * String.charCodeAt
  * String.concat
  * String.contains
  * String.endsWith
  * String.includes
  * String.indexOf
  * String.lastIndexOf
  * String.localeCompare
  * String.match
  * String.normalize
  * String.replace
  * String.search
  * String.slice
  * String.split
  * String.startsWith
  * String.substr
  * String.substring
  * String.toLocaleLowerCase
  * String.toLocaleUpperCase
  * String.toLowerCase
  * String.toUpperCase
  * String.trim
  * String.trimLeft
  * String.trimRight

Comment 1

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Attachment: Bug 1321274 - Remove usage of javascript String generics.

Review commit: https://reviewboard.mozilla.org/r/96586/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/96586/

Comment 2

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Attachment: Bug 1321274 - Remove usage of javascript String generics: chat/im.

Review commit: https://reviewboard.mozilla.org/r/96588/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/96588/

Comment 3

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Attachment: Bug 1321274 - Remove usage of javascript String generics: mail.

Review commit: https://reviewboard.mozilla.org/r/96590/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/96590/

Comment 4

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Comment on attachment 8815780 [details]
Bug 1321274 - Remove usage of javascript String generics.

https://reviewboard.mozilla.org/r/96586/#review96796

Comment 5

[aleth [:aleth]]

Comment on attachment 8815781 [details]
Bug 1321274 - Remove usage of javascript String generics: chat/im.

https://reviewboard.mozilla.org/r/96588/#review96804

Comment 6

[Magnus Melin [:mkmelin]]

Comment on attachment 8815782 [details]
Bug 1321274 - Remove usage of javascript String generics: mail.

https://reviewboard.mozilla.org/r/96590/#review97260

LGTM! r=mkmmelin

Comment 7

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

calendar: https://hg.mozilla.org/comm-central/rev/712ce63ce4be9b922a85af8f06fd81b4d30a8b8b
chat & im: https://hg.mozilla.org/comm-central/rev/14dc361515067ad74811e70543cc4acc7266e212
mail: https://hg.mozilla.org/comm-central/rev/fa53301f7178e84b38403e83dfaa7f71a28f357a