Closed
Bug 1321285
Opened 8 years ago
Closed 6 years ago
Remove a potential unused overload in mfbt/AlreadyAddRefed.h
Categories
(Core :: MFBT, defect)
Core
MFBT
Tracking
()
VERIFIED
WONTFIX
People
(Reporter: Sylvestre, Unassigned)
References
Details
Attachments
(1 obsolete file)
Removing it makes gcc 7 happy but not sure it doesn't have side effects elsewhere.
In file included from /root/firefox-gcc-last/obj-x86_64-pc-linux-gnu/dist/include/nsCOMPtr.h:23:0,
from /root/firefox-gcc-last/obj-x86_64-pc-linux-gnu/dist/include/nsIWeakReferenceUtils.h:10,
from /root/firefox-gcc-last/obj-x86_64-pc-linux-gnu/dist/include/nsWeakReference.h:14,
from /root/firefox-gcc-last/toolkit/components/places/Database.h:9,
from /root/firefox-gcc-last/toolkit/components/places/Database.cpp:9,
from /root/firefox-gcc-last/obj-x86_64-pc-linux-gnu/toolkit/components/places/Unified_cpp_components_places0.cpp:2:
/root/firefox-gcc-last/obj-x86_64-pc-linux-gnu/dist/include/mozilla/AlreadyAddRefed.h:107:15: error: 'void operator<<(const mozilla::unused_t&, const already_AddRefed<nsRunnableMethod<mozilla::places::{anonymous}::VisitedQuery, nsresult, true, false> >&)' declared 'static' but never defined [-Werror=unused-function]
friend void operator<<(const mozilla::unused_t& aUnused,
^~~~~~~~
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
|
Reporter | |
Comment 4•8 years ago
|
||
This is breaking linux debug:
[task 2016-11-30T15:51:11.078202Z] 15:51:11 INFO - Assertion failure: !mRawPtr, at /home/worker/workspace/build/src/obj-firefox/dist/include/mozilla/AlreadyAddRefed.h:101
Windows:
15:57:27 INFO - Executing z:/build/build/src/obj-firefox/dist\bin\xpcshell.exe -g z:\build\build\src\obj-firefox\dist\bin/ -a z:\build\build\src\obj-firefox\dist\bin/ -f z:/build/build/src/toolkit/mozapps/installer\precompile_cache.js -e precompile_startupcache("resource://gre/");
15:57:27 INFO - Assertion failure: !mRawPtr, at z:\build\build\src\obj-firefox\dist\include\mozilla/AlreadyAddRefed.h:101
|
|
Reporter | |
Comment 5•8 years ago
|
||
| mozreview-review | ||
Comment on attachment 8815702 [details]
Bug 1321285 - Remove a potential unused overload in mfbt/AlreadyAddRefed.h
https://reviewboard.mozilla.org/r/96552/#review97456
Doesn't work at all
|
|
Reporter | |
Updated•8 years ago
|
Attachment #8815702 -
Attachment is obsolete: true
|
||
Comment 6•6 years ago
|
||
Per policy at https://wiki.mozilla.org/Bug_Triage/Projects/Bug_Handling/Bug_Husbandry#Inactive_Bugs. If this bug is not an enhancement request or a bug not present in a supported release of Firefox, then it may be reopened.
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → INACTIVE
|
|
Reporter | |
Comment 7•6 years ago
|
||
I don't think we have it anymore.
Status: RESOLVED → VERIFIED
Resolution: INACTIVE → WONTFIX
You need to log in
before you can comment on or make changes to this bug.
Description
•