1321296 - GYP build fails to disable -Werror for GCC 4.2

Status: RESOLVED FIXED

(NSS :: Build, defect)

Description

[Jan Beich]

$ ./build.sh
[...]
FAILED: obj/lib/smime/smime.smimeutil.o
cc -MMD -MF obj/lib/smime/smime.smimeutil.o.d -DNSS_NO_INIT_SUPPORT -DUSE_UTIL_DIRECTLY -DNO_NSPR_10_SUPPORT -DSSL_DISABLE_DEPRECATED_CIPHER_SUITE_NAMES -DFREEBSD -DHAVE_BSD_FLOCK -DHAVE_STRERROR -DXP_UNIX -D_REENTRANT -DNSS_DISABLE_LIBPKIX -DDEBUG -I/tmp/dist/Debug/include/nspr -I/tmp/dist/private/nss -I/tmp/dist/public/nss -fPIC -pipe -ffunction-sections -fdata-sections -m32 -Werror -Wall -g -gdwarf-2   -c ../../lib/smime/smimeutil.c -o obj/lib/smime/smime.smimeutil.o
In file included from ../../lib/smime/smimeutil.c:759:
/tmp/dist/private/nss/verref.h: In function 'NSSSMIME_VersionCheck':
/tmp/dist/private/nss/verref.h:22: error: #pragma GCC diagnostic not allowed inside functions
/tmp/dist/private/nss/verref.h:23: error: #pragma GCC diagnostic not allowed inside functions
/tmp/dist/private/nss/verref.h:42: error: #pragma GCC diagnostic not allowed inside functions
[249/898] CC obj/lib/sqlite/sqlite.sqlite3.o
ninja: build stopped: subcommand failed.

$ cc -v
Using built-in specs.
Target: i386-undermydesk-freebsd
Configured with: FreeBSD/i386 system compiler
Thread model: posix
gcc version 4.2.1 20070831 patched [FreeBSD]

$ uname -sr
FreeBSD 9.3-RELEASE-p50

Comment 1

[Landry Breuil (:gaston)]

Same thing for OpenBSD of course.

Comment 2

[Jan Beich]

Attachment: v1

https://treeherder.mozilla.org/#/jobs?repo=nss-try&revision=878788052401075b3fb0e202226cd693434cccc8

Comment 3

[Jan Beich]

Attachment: v1.1

Oops, forgot about python 3.x.

https://treeherder.mozilla.org/#/jobs?repo=nss-try&revision=a1b70b3cf126b7f22962182b26faa68100af006f

Comment 4

[Martin Thomson [:mt:]]

Comment on attachment 8815717 [details] [diff] [review]
v1.1

Review of attachment 8815717 [details] [diff] [review]:
-----------------------------------------------------------------

Gah, I hate languages with implicit conversion.  Thanks.

https://hg.mozilla.org/projects/nss/rev/1403acb9208bc75b42fb6929cc980fe441da95f7

Comment 5

[Martin Thomson [:mt:]]

Ugh, you guys really need to start using newer compilers.  At least you are using recent versions of NSS :)

Comment 6

[Landry Breuil (:gaston)]

(In reply to Martin Thomson [:mt:] from comment #5)
> Ugh, you guys really need to start using newer compilers.  At least you are
> using recent versions of NSS :)

Yeah, policy and licences.. gcc 4.2.1 was the last one under GPLv2, but we're in the process of switching to clang/llvm someday :)

Comment 7

[(not currently active) Ted Mielczarek]

FYI for version tests like this there's a `LooseVersion` class hiding in the Python standard library, so you could write something like:
from distutils.version import LooseVersion

if LooseVersion(v.strip(' \r\n')) < '4.8':