132133 - [PATCH]Text Area: deleting last char on line can move caret to prior line

Status: VERIFIED FIXED

(Core :: DOM: Editor, defect, P1)

Description

[Joe Francis]

In bug 92124, Shotaro Kamio wrote:

Created an attachment (id=74689)
test case with no mozBR

Try to delete the last line on this test case.
This case has no relation with HINTRIGHT.
So, all you have to do is to delete the last line with BS or DEL key.

The problem of this case comes from the lack of last mozBR.

Comment 1

[Joe Francis]

Attachment: test case

bringing over skamio's test case from bug 92124

Comment 2

[Joe Francis]

nominating: text area weirdness is high priority prob.

Comment 3

[Joe Francis]

Shotaro, I have looked at the patch you provided (in 92124).  Your' diagnosis of 
the problem is absolutely correct, but I agree that the correct thing to do is to 
put a MozBR at the end of the textarea.  But I think checking for empty text 
nodes is the wrong way to go about it.

I'll try to post a new patch shortly.  Thanks for your help discovering and 
diagnosing this problem!

Comment 4

[Syd Logan]

worksforme 2002032112 winblows netscape build

Comment 5

[kinmoz]

I still see this bug in my build from today! REOPENING.

Comment 6

[Syd Logan]

plusing

Comment 7

[Joe Francis]

Attachment: patch to nsTextEditRules.h,cpp

Force plaintext editors to have a trailing br.

Comment 8

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

Comment on attachment 77017 [details] [diff] [review]
patch to nsTextEditRules.h,cpp

r=glazman

Comment 9

[kinmoz]

Comment on attachment 77017 [details] [diff] [review]
patch to nsTextEditRules.h,cpp

Should CreateTrailingBRIfNeeded() only work when these flags are lit
(eEditorWidgetMask and eEditorWidgetMask) and eEditorSingleLineMask isn't? In
otherwords, only when we're in a multi-lined textarea. I'm just worried about
potential single-line textfield caret navigation and output problems. I may
just be paranoid.

If we assume CreateBogusNodeIfNeeded() is called first, how can we have
!lastChild in CreateTrailingBRIfNeeded()? Shouldn't that be an error if it is
null?

Comment 10

[kinmoz]

Comment on attachment 77017 [details] [diff] [review]
patch to nsTextEditRules.h,cpp

sr=[e-mail] as long as this only impacts textareas. Please test form
submission and widget output.

Comment 11

[Kevin McCluskey (gone)]

adt1.0.0

Comment 12

[Asa Dotzler [:asa]]

Comment on attachment 77017 [details] [diff] [review]
patch to nsTextEditRules.h,cpp

a=asa (on behalf of drivers) for checkin to the 1.0 trunk

Comment 13

[Jaime Rodriguez, Jr.]

adt1.0.0+ (on ADT's behalf) approval for checkin into 1.0.

Comment 14

[Joe Francis]

fix landed on trunk

Comment 15

[sujay]

verified in 4/8 build.

Comment 16

[Joe Francis]

This landed before branch cut.  Hence: fixed1.0.0