1321371 - single head per branch hook doesn't ignore hidden changesets

Status: RESOLVED FIXED

(Developer Services :: Mercurial: hg.mozilla.org, defect)

Description

[Gregory Szorc [:gps]]

The single head per branch hook apparently gives false positives when there are hidden changesets involved. This was found as part of doing history rewriting in bug 1321184.

Comment 1

[Gregory Szorc [:gps]]

This bit us again today. Enough is enough.

Comment 2

[Gregory Szorc [:gps]]

Attachment: hghooks: refactor code to facilitate more complex conditionals;

This will make the next commit easier to read. While we could retain a
list comprehension in the next commit, we want to avoid constructing
changectx for perf reasons.

Review commit: https://reviewboard.mozilla.org/r/98674/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/98674/

Comment 3

[Gregory Szorc [:gps]]

Attachment: hghooks: add test for hidden heads (bug 1321371);

This test demonstrates the hook currently incorrectly counts hidden
changesets against the heads count.

Review commit: https://reviewboard.mozilla.org/r/98676/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/98676/

Comment 4

[Gregory Szorc [:gps]]

Attachment: hghooks: filter out hidden changesets (bug 1321371);

This makes the hook work properly when a repository has hidden
changesets.

Review commit: https://reviewboard.mozilla.org/r/98678/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/98678/

Comment 5

[Steven MacLeod [:smacleod]]

Comment on attachment 8818729 [details]
hghooks: refactor code to facilitate more complex conditionals;

https://reviewboard.mozilla.org/r/98674/#review103654

Comment 6

[Steven MacLeod [:smacleod]]

Comment on attachment 8818730 [details]
hghooks: add test for hidden heads (bug 1321371);

https://reviewboard.mozilla.org/r/98676/#review103656

Comment 7

[Steven MacLeod [:smacleod]]

Comment on attachment 8818731 [details]
hghooks: filter out hidden changesets (bug 1321371);

https://reviewboard.mozilla.org/r/98678/#review103658

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/hgcustom/version-control-tools/rev/8e257192382b
hghooks: add test for hidden heads ; r=smacleod
https://hg.mozilla.org/hgcustom/version-control-tools/rev/d32600ce41c7
hghooks: filter out hidden changesets ; r=smacleod