1321372 - ESR45, MacOS Sierra: /media/webrtc/trunk/webrtc/modules/video_capture/mac/qtkit/video_capture_qtkit.h:14:9: fatal error: 'QTKit/QTKit.h' file not found

Status: RESOLVED WORKSFORME

(Core :: WebRTC, defect, P4)

Description

[Alex Vincent [:WeirdAl]]

[Tracking Requested - why for this release]:
Build bustage on MacOS 10.12 for Firefox 45 ESR.

Comment 1

[Alex Vincent [:WeirdAl]]

Unfortunately, this file has been deleted or moved in mozilla-central since...

Comment 2

[Nomis101]

This was removed in Bug 1275217 for mozilla49, in favor of AVFoundation, which is Bug 1180725.
You see this because it was removed in macOS 10.12.:
https://developer.apple.com/library/prerelease/content/releasenotes/Miscellaneous/APIDiffsMacOS10_12/Objective-C/QTKit.html

Comment 3

[Randell Jesup [:jesup] (needinfo me)]

Munro - perhaps there's a tweak that can be made to ESR45 to allow it to build on MacOSX sierra

Comment 4

[Munro Mengjue Chiang [:mchiang] Be Mozillian since 1/19/2018]

https://developer.apple.com/library/prerelease/content/releasenotes/General/APIDiffsMacOS10_12/Objective-C/QTKit.html

QTKit.framework has been completely removed from /system/library/frameworks/ since sierra.
I am afraid we need to migrate ESR45 to AV Foundation.

Comment 5

[Alex Vincent [:WeirdAl]]

Is a change that significant going to be approved for an ESR release?  If not, I will gladly take a patch and build it locally for my company's needs.

I ask because while I moved to OSX Sierra, it's entirely possible the larger community of ESR users hasn't and won't in the next four months (before the next ESR arrives).

Comment 6

[Munro Mengjue Chiang [:mchiang] Be Mozillian since 1/19/2018]

Please apply the following patches.

hg import https://hg.mozilla.org/mozilla-central/raw-rev/9fa7e2a17ee9
hg import https://hg.mozilla.org/mozilla-central/raw-rev/fcedd1b3ef25
hg import https://hg.mozilla.org/mozilla-central/raw-rev/b779a53247e2
hg import https://hg.mozilla.org/mozilla-central/raw-rev/0680e3176fa5
hg import https://hg.mozilla.org/mozilla-central/raw-rev/0b1ae9f4f07b

Then you can get rid of the "'QTKit/QTKit.h' file not found" fatal error.

Comment 7

[Randell Jesup [:jesup] (needinfo me)]

(In reply to Alex Vincent [:WeirdAl] from comment #5)
> Is a change that significant going to be approved for an ESR release?  If
> not, I will gladly take a patch and build it locally for my company's needs.
> 
> I ask because while I moved to OSX Sierra, it's entirely possible the larger
> community of ESR users hasn't and won't in the next four months (before the
> next ESR arrives).

And more to the point, this only affects people *building* on Sierra, not using it on Sierra. And that's a far smaller group than all of ESR

Comment 8

[Alex Vincent [:WeirdAl]]

Those patches appear to be exactly what I need to finish the build and get an operable ESR45 from OSX Sierra.  Thank you very much.

Now, I leave it up to the Powers That Be In The Approval Chain to decide whether this goes in or not, per comment 7.

Comment 9

[Sylvestre Ledru [:Sylvestre]]

esr 45 is dead, please use esr 52

Comment 10

[Bulk Bug Changes for mreavy's org]

Mass change P3->P4 to align with new Mozilla triage process.

Comment 11

[Petruta Horea [:phorea], Desktop Test Engineering]

Closing as RWFM since a solution was given to the reporter and the OS + Firefox version reported against are old.