Closed Bug 1321387 Opened 3 years ago Closed 3 years ago

Preemptively fix unified bustage in layout/generic

Categories

(Core :: Layout, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla53
Tracking Status
firefox53 --- fixed

People

(Reporter: dholbert, Assigned: dholbert)

Details

Attachments

(6 files)

As in bug 1321056, let's preemptively discover & fix unified-build bustage in layout/generic (by locally replacing UNIFIED_SOURCES with SOURCES).
(I've included explanations for any non-obvious changes in the extended commit messages.)
Comment on attachment 8815889 [details]
Bug 1321387 part 1: Wrap ReflowOutput impl in "namespace mozilla {}".

https://reviewboard.mozilla.org/r/96666/#review97002
Attachment #8815889 - Flags: review?(tlin) → review+
Comment on attachment 8815890 [details]
Bug 1321387 part 2: Add missing "using namespace" declarations to a few .cpp files in layout/generic.

https://reviewboard.mozilla.org/r/96668/#review97004
Attachment #8815890 - Flags: review?(tlin) → review+
Comment on attachment 8815891 [details]
Bug 1321387 part 3: Add "mozilla::" namespace prefix to some types in header files.

https://reviewboard.mozilla.org/r/96670/#review97006
Attachment #8815891 - Flags: review?(tlin) → review+
Comment on attachment 8815892 [details]
Bug 1321387 part 4: Add #includes to some .cpp files in layout/generic, to provide types/definitions used in those files.

https://reviewboard.mozilla.org/r/96672/#review97008
Attachment #8815892 - Flags: review?(tlin) → review+
Comment on attachment 8815893 [details]
Bug 1321387 part 5: Sort RubyUtils.h's #include list.

https://reviewboard.mozilla.org/r/96674/#review97010
Attachment #8815893 - Flags: review?(tlin) → review+
Comment on attachment 8815894 [details]
Bug 1321387 part 6: Add #includes & forward declarations to some headers in layout/generic, to provide types used in those files.

https://reviewboard.mozilla.org/r/96690/#review97012
Attachment #8815894 - Flags: review?(tlin) → review+
(In reply to Daniel Holbert [:dholbert] from comment #7)
> (I've included explanations for any non-obvious changes in the extended
> commit messages.)

Your explanations are all very clear to me. Thank you for fixing this.
Pushed by dholbert@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5dc43b5e3673
part 1: Wrap ReflowOutput impl in "namespace mozilla {}". r=TYLin
https://hg.mozilla.org/integration/autoland/rev/7fd228039333
part 2: Add missing "using namespace" declarations to a few .cpp files in layout/generic. r=TYLin
https://hg.mozilla.org/integration/autoland/rev/ba9d56ef7f5a
part 3: Add "mozilla::" namespace prefix to some types in header files. r=TYLin
https://hg.mozilla.org/integration/autoland/rev/ad0a04a3a869
part 4: Add #includes to some .cpp files in layout/generic, to provide types/definitions used in those files. r=TYLin
https://hg.mozilla.org/integration/autoland/rev/9fc8534e92e2
part 5: Sort RubyUtils.h's #include list. r=TYLin
https://hg.mozilla.org/integration/autoland/rev/1fa4b27c956f
part 6: Add #includes & forward declarations to some headers in layout/generic, to provide types used in those files. r=TYLin
Thanks for the review!

FWIW, this patch-stack is part of a mostly-complete (& green so far) Try run here:
 https://treeherder.mozilla.org/#/jobs?repo=try&revision=393d2226e46c
...so I went ahead and landed.
You need to log in before you can comment on or make changes to this bug.