1321467 - Display grid line numbers doesn't work with extended grid lines

Status: VERIFIED FIXED

(DevTools :: Inspector, defect, P3)

Description

[Gabriel Luong [:gl] (ΦωΦ)]

Currently, the grid line numbers are displayed off the screen as a result of the extending the grid lines infinitely.

Comment 1

[Julian Descottes [:jdescottes]]

Attachment: Bug 1321467 - display grid line numbers with extended grid lines;

Clamp the x and y positions for the grid line numbers to make sure they
are always visible, even if extended grid lines is turned on.

Review commit: https://reviewboard.mozilla.org/r/114154/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/114154/

Comment 2

[Matteo Ferretti [:zer0] [:matteo]]

Comment on attachment 8839553 [details]
Bug 1321467 - display grid line numbers with extended grid lines;

https://reviewboard.mozilla.org/r/114154/#review115910

Looks good to me!
However I'm not sure I was able to reproduce the original issue properly, is there a test page where we can see it?
Plus, I think we should probably fix the current line number alignment, but I'll file a new bug for that.

Comment 3

[Julian Descottes [:jdescottes]]

Thanks for the review! I used the following STRS:

- go to http://labs.jensimmons.com/examples/grid-content-1.html
- open layout panel
- check any of the available grids
- check "Display numbers on lines"
- check "Extend grid lines infinitely"

AR: line numbers disappear
ER: line numbers should still be visible

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c1d68f17f3c7
display grid line numbers with extended grid lines;r=zer0

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/c1d68f17f3c7

Comment 6

[roxleitan]

Verified fixed using the latest Nightly 54.0a1 (2017-03-01) on Ubuntu 16.04, Mac OS X 10.11 and Windows 10 x64 with the STR from comment 3.