Closed Bug 1321467 Opened 3 years ago Closed 3 years ago

Display grid line numbers doesn't work with extended grid lines

Categories

(DevTools :: Inspector, defect, P3)

defect

Tracking

(firefox54 verified)

VERIFIED FIXED
Firefox 54
Tracking Status
firefox54 --- verified

People

(Reporter: gl, Assigned: jdescottes)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Currently, the grid line numbers are displayed off the screen as a result of the extending the grid lines infinitely.
Blocks: dt-grid
Assignee: nobody → jdescottes
Status: NEW → ASSIGNED
Comment on attachment 8839553 [details]
Bug 1321467 - display grid line numbers with extended grid lines;

https://reviewboard.mozilla.org/r/114154/#review115910

Looks good to me!
However I'm not sure I was able to reproduce the original issue properly, is there a test page where we can see it?
Plus, I think we should probably fix the current line number alignment, but I'll file a new bug for that.
Attachment #8839553 - Flags: review?(zer0) → review+
Thanks for the review! I used the following STRS:

- go to http://labs.jensimmons.com/examples/grid-content-1.html
- open layout panel
- check any of the available grids
- check "Display numbers on lines"
- check "Extend grid lines infinitely"

AR: line numbers disappear
ER: line numbers should still be visible
Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c1d68f17f3c7
display grid line numbers with extended grid lines;r=zer0
https://hg.mozilla.org/mozilla-central/rev/c1d68f17f3c7
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 54
Flags: qe-verify+
Verified fixed using the latest Nightly 54.0a1 (2017-03-01) on Ubuntu 16.04, Mac OS X 10.11 and Windows 10 x64 with the STR from comment 3.
Status: RESOLVED → VERIFIED
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.