Closed
Bug 1321480
Opened 8 years ago
Closed 8 years ago
Firefox Puppeteer has to use Marionette's "page load" timeout
Categories
(Testing :: Firefox UI Tests, defect)
Tracking
(firefox52 fixed, firefox53 fixed)
RESOLVED
FIXED
mozilla53
People
(Reporter: whimboo, Assigned: adrianzatreanu1, Mentored)
References
Details
(Whiteboard: [lang=py])
Attachments
(1 file)
Right now we define our own value for the page load timeout: https://hg.mozilla.org/mozilla-central/file/324855/testing/marionette/puppeteer/firefox/firefox_puppeteer/ui/browser/window.py#l48 It's been in use in a couple of firefox-ui tests under testing/firefox-ui/tests. We should change that so we make use of self.marionette.timeout.page_load instead. It also means that this specific property from above can be removed.
Reporter | ||
Comment 1•8 years ago
|
||
Adrian, are you interested to pick up this bug as your first one?
Mentor: hskupin
Whiteboard: [lang=py]
Reporter | ||
Updated•8 years ago
|
Flags: needinfo?(adrianzatreanu1)
Assignee | ||
Comment 2•8 years ago
|
||
Sure thing! :)
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Assignee | ||
Updated•8 years ago
|
Flags: needinfo?(adrianzatreanu1)
Assignee | ||
Updated•8 years ago
|
Attachment #8816094 -
Flags: review?(hskupin)
Reporter | ||
Comment 5•8 years ago
|
||
mozreview-review |
Comment on attachment 8816094 [details] Bug 1321480: Make Firefox Puppeteer use Marionette's "page load" timeout https://reviewboard.mozilla.org/r/96894/#review97154 The patch looks great and updates all the instances we currently have for that timeout property. The try build was also fine, so I'm going to push this patch in a bit to autoland. Thanks a lot for your work! It's great to see that you were able to get all of this done with any further help.
Attachment #8816094 -
Flags: review?(hskupin) → review+
Reporter | ||
Comment 6•8 years ago
|
||
mozreview-review |
Comment on attachment 8816094 [details] Bug 1321480: Make Firefox Puppeteer use Marionette's "page load" timeout https://reviewboard.mozilla.org/r/96894/#review97156 Oh, would you mind to please update the commit message so it sounds what the bug summary says? Once done I will push it. Thanks.
Comment hidden (mozreview-request) |
Pushed by hskupin@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a3d8baec7db0 Make Firefox Puppeteer use Marionette's "page load" timeout r=whimboo
Comment 9•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/a3d8baec7db0
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox53:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
Reporter | ||
Comment 10•8 years ago
|
||
Test-only change which will make our tests more stable for remote page loads. Please uplift to aurora. Thanks.
Assignee: nobody → adrianzatreanu1
status-firefox52:
--- → affected
Whiteboard: [lang=py] → [lang=py][checkin-needed-aurora]
Comment 11•8 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-aurora/rev/988ab8a46590
Flags: in-testsuite+
Whiteboard: [lang=py][checkin-needed-aurora] → [lang=py]
You need to log in
before you can comment on or make changes to this bug.
Description
•