Closed Bug 1321480 Opened 4 years ago Closed 4 years ago
Firefox Puppeteer has to use Marionette's "page load" timeout
58 bytes, text/x-review-board-request
Right now we define our own value for the page load timeout: https://hg.mozilla.org/mozilla-central/file/324855/testing/marionette/puppeteer/firefox/firefox_puppeteer/ui/browser/window.py#l48 It's been in use in a couple of firefox-ui tests under testing/firefox-ui/tests. We should change that so we make use of self.marionette.timeout.page_load instead. It also means that this specific property from above can be removed.
Adrian, are you interested to pick up this bug as your first one?
Sure thing! :)
Comment on attachment 8816094 [details] Bug 1321480: Make Firefox Puppeteer use Marionette's "page load" timeout https://reviewboard.mozilla.org/r/96894/#review97154 The patch looks great and updates all the instances we currently have for that timeout property. The try build was also fine, so I'm going to push this patch in a bit to autoland. Thanks a lot for your work! It's great to see that you were able to get all of this done with any further help.
Attachment #8816094 - Flags: review?(hskupin) → review+
Comment on attachment 8816094 [details] Bug 1321480: Make Firefox Puppeteer use Marionette's "page load" timeout https://reviewboard.mozilla.org/r/96894/#review97156 Oh, would you mind to please update the commit message so it sounds what the bug summary says? Once done I will push it. Thanks.
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/a3d8baec7db0 Make Firefox Puppeteer use Marionette's "page load" timeout r=whimboo
Test-only change which will make our tests more stable for remote page loads. Please uplift to aurora. Thanks.
You need to log in before you can comment on or make changes to this bug.