1321568 - Crash in java.lang.UnsupportedOperationException: at org.mozilla.gecko.prompts.Prompt.addInputValues(Prompt.java)

Status: VERIFIED FIXED

(Core Graveyard :: Widget: Android, defect)

Description

[Marcia Knous [:marcia]]

This bug was filed from the Socorro interface and is 
report bp-52a98e2d-dc6a-4135-bc42-b9bd22161201.
=============================================================

Seen while viewing Nightly crash stats - #3 crash on nightly that had no bug filed: http://bit.ly/2gYTNWb. Looks as if all crashes are on Build 20161130030206 so far. Uptime range indicates it is a startup crash.

Comment 1

[Dave Miller [:justdave]]

I'm getting this crash and willing to help debug...

I suspect it's related to LastPass.  I have the LastPass add-on installed, and changed my master password recently from a different web browser.  It's now prompting me with "LastPass: Invalid password!" shortly after the browser starts. When I try to log back into LastPass with the correct password, I get this crash immediately when hitting OK on the login dialog.

Comment 2

[Michal Stanke (Mozilla.cz) [:mstanke][:MikkCZ]]

I experience this bug for several days two. The steps to reproduce are:
1) Open Fennec Nightly.
2) Have master password set up.
3) Go to any site with login credentials stored for.
4) When the master password dialog opens, do whatever you want.

In step 4, either you enter the password or tap Cancel, the dialog will appear for the second time, than Nightly freezes and crash. No add-on like LastPass installed, only uBlock origin, but happened to me with Adblock plus too. Also not it is not a startup bug. I have tried to wait for few minutes before going to a site asking for password, but the result was the same.

Comment 3

[Kartikaya Gupta (email:[e-mail])]

I'm also getting this crash, after entering http auth credentials. STR:
1. Go to https://staktrace.com/apps/bugmash/dashboard.php
2. Enter a username and password (anything will do)
3. Hit ok
4. Crash

Comment 4

[Adrian Aichner [:anaran]]

I see the same as comment 2 describes, without any of the add-ons installed.
Problem is still around with today's build:

https://crash-stats.mozilla.com/report/index/4a5b8c6a-2386-4493-a846-e32de2161207

Comment 5

[Kartikaya Gupta (email:[e-mail])]

Jim, looks like a regression from your recent change.

Comment 6

[Dave Miller [:justdave]]

ok, so LastPass is only involved because it's using an input control, and any old input control triggers it, looks like.

Comment 7

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Handle null and CharSequence prompt values (v1)

Correctly handle null values and CharSequence values (that are not
Strings) returned by prompt inputs. r=me for trivial patch.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c6face1d7183
Handle null and CharSequence prompt values; r=me

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/c6face1d7183

Comment 10

[Adrian Aichner [:anaran]]

I am glad to confirm this problem fixed in

appid	{aa3c5121-dab2-40e2-81ca-7ea25febc110}
apptype	mobile/android
vendor	Mozilla
name	Fennec
version	53.0a1
appbuildid	20161210030206
platformbuildid	20161210030206
geckobuildid	20161210030206
platformversion	53.0a1
geckoversion	53.0a1

both for entering a master password and for canceling out of the dialog.

Comment 11

[Dave Miller [:justdave]]

Ditto, confirming fixed for me, too.

Comment 12

[Nicholas Nethercote [inactive]]

Further confirmation: this crash occurred 28 times in Nightly 20161209030212 but hasn't appeared since.