1321571 - text_ext_storage_sync.js:ensureKeysFor_posts_new_keys pushes keys too many times

Status: RESOLVED FIXED

(WebExtensions :: Untriaged, defect, P2)

Description

[Ethan Glasser-Camp (:glasserc)]

The changes in bug 1319742 seem to uncover a strange behavior in kinto.js where it repeatedly pushes a server record during a server_wins conflict. I think this may be due to a bug in kinto.js's deepEqual function, similar to https://github.com/Kinto/kinto.js/pull/529.

Comment 1

[Ethan Glasser-Camp (:glasserc)]

Attachment: Bug 1321571 - ensureKeysFor_posts_new_keys pushes keys too many times,

The kinto.js library assumes that all records coming from the server
will have a last_modified date, and copy it before checking for
equality. That date was missing here because I mocked a fake Kinto
server, so the code to check that the conflict was resolved
successfully got confused.

Review commit: https://reviewboard.mozilla.org/r/101230/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/101230/

Comment 2

[Ethan Glasser-Camp (:glasserc)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=9b10d513ccf1

Comment 3

[Mark Hammond [:markh] [:mhammond]]

Comment on attachment 8822258 [details]
Bug 1321571 - ensureKeysFor_posts_new_keys pushes keys too many times,

https://reviewboard.mozilla.org/r/101230/#review102150

Comment 4

[Ethan Glasser-Camp (:glasserc)]

Since I just touched one test, I'm pretty sure the failures on try are unrelated.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/418194476bdd
ensureKeysFor_posts_new_keys pushes keys too many times, r=markh

Comment 6

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/418194476bdd