Closed Bug 1321571 Opened 5 years ago Closed 5 years ago

text_ext_storage_sync.js:ensureKeysFor_posts_new_keys pushes keys too many times

Categories

(WebExtensions :: Untriaged, defect, P2)

defect

Tracking

(firefox53 fixed)

RESOLVED FIXED
mozilla53
Tracking Status
firefox53 --- fixed

People

(Reporter: glasserc, Assigned: glasserc)

Details

(Whiteboard: triaged)

Attachments

(1 file)

The changes in bug 1319742 seem to uncover a strange behavior in kinto.js where it repeatedly pushes a server record during a server_wins conflict. I think this may be due to a bug in kinto.js's deepEqual function, similar to https://github.com/Kinto/kinto.js/pull/529.
Assignee: nobody → eglassercamp
Priority: -- → P2
Whiteboard: triaged
Comment on attachment 8822258 [details]
Bug 1321571 - ensureKeysFor_posts_new_keys pushes keys too many times,

https://reviewboard.mozilla.org/r/101230/#review102150
Attachment #8822258 - Flags: review?(markh) → review+
Since I just touched one test, I'm pretty sure the failures on try are unrelated.
Keywords: checkin-needed
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/418194476bdd
ensureKeysFor_posts_new_keys pushes keys too many times, r=markh
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/418194476bdd
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
Product: Toolkit → WebExtensions
You need to log in before you can comment on or make changes to this bug.