text_ext_storage_sync.js:ensureKeysFor_posts_new_keys pushes keys too many times

RESOLVED FIXED in Firefox 53

Status

()

Toolkit
WebExtensions: Untriaged
P2
normal
RESOLVED FIXED
11 months ago
10 months ago

People

(Reporter: glasserc, Assigned: glasserc)

Tracking

unspecified
mozilla53
Points:
---

Firefox Tracking Flags

(firefox53 fixed)

Details

(Whiteboard: triaged)

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

11 months ago
The changes in bug 1319742 seem to uncover a strange behavior in kinto.js where it repeatedly pushes a server record during a server_wins conflict. I think this may be due to a bug in kinto.js's deepEqual function, similar to https://github.com/Kinto/kinto.js/pull/529.
(Assignee)

Updated

11 months ago
Assignee: nobody → eglassercamp

Updated

10 months ago
Priority: -- → P2
Whiteboard: triaged
Comment hidden (mozreview-request)
(Assignee)

Comment 2

10 months ago
https://treeherder.mozilla.org/#/jobs?repo=try&revision=9b10d513ccf1

Comment 3

10 months ago
mozreview-review
Comment on attachment 8822258 [details]
Bug 1321571 - ensureKeysFor_posts_new_keys pushes keys too many times,

https://reviewboard.mozilla.org/r/101230/#review102150
Attachment #8822258 - Flags: review?(markh) → review+
(Assignee)

Comment 4

10 months ago
Since I just touched one test, I'm pretty sure the failures on try are unrelated.
Keywords: checkin-needed

Comment 5

10 months ago
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/418194476bdd
ensureKeysFor_posts_new_keys pushes keys too many times, r=markh
Keywords: checkin-needed

Comment 6

10 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/418194476bdd
Status: NEW → RESOLVED
Last Resolved: 10 months ago
status-firefox53: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
You need to log in before you can comment on or make changes to this bug.