1321615 - (Re-)add tests for webrequest modifications of top level loads

Status: RESOLVED FIXED

(WebExtensions :: Request Handling, defect, P1)

Description

[Andrew Swan [:aswan]]

Bug 1314492 was a large refactoring of the webrequest tests.  But it also inadvertently dropped test coverage for blocking webrequest listeners that modify top level loads (or more specifically, loads without a loading principal).
Note that this is similar to but not the same as bug 1318800 which was just about passive listeners.

Comment 1

[Shane Caraveo (:mixedpuppy)]

Attachment: Bug 1321615 fix tests for header modification in toplevel loads,

Review commit: https://reviewboard.mozilla.org/r/97040/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/97040/

Comment 2

[Kris Maglione [:kmag]]

Comment on attachment 8816241 [details]
Bug 1321615 fix tests for header modification in toplevel loads,

https://reviewboard.mozilla.org/r/97040/#review97264

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4c343bdb6e2a
fix tests for header modification in toplevel loads, r=kmag

Comment 4

[Phil Ringnalda (:philor)]

Backed out in https://hg.mozilla.org/integration/autoland/rev/cf2d377f4a5f for https://treeherder.mozilla.org/logviewer.html#?job_id=7609082&repo=autoland

Comment 5

[Shane Caraveo (:mixedpuppy)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=54f0f01bba5d

Comment 6

[Shane Caraveo (:mixedpuppy)]

Comment on attachment 8816241 [details]
Bug 1321615 fix tests for header modification in toplevel loads,

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/97040/diff/1-2/

Comment 7

[Shane Caraveo (:mixedpuppy)]

The curious thing about this failure is that it fails in a way that doesn't make sense.  We test for a valid array, then use array.find which throws undefined (log below).

I was unable to repro on try in comment 5, so I'm going to try re-landing this.  There has been some flux in the webrequest code, so the cause may have been addressed.


INFO - TEST-PASS | browser/components/extensions/test/browser/browser_ext_webRequest.js | valid responseHeaders array - 
INFO - Console message: [JavaScript Error: "headers.find(...) is undefined" {file: "moz-extension://9ccd484f-f7c2-48e0-b1af-863a1bb49c89/%7B9857a585-a039-4142-86cd-0140d50ab68a%7D.js" line: 128}]
INFO - checkHeaders@moz-extension://9ccd484f-f7c2-48e0-b1af-863a1bb49c89/%7B9857a585-a039-4142-86cd-0140d50ab68a%7D.js:128:19

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3fa1db0853db
fix tests for header modification in toplevel loads, r=kmag

Comment 9

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/3fa1db0853db