1321750 - Got gcc: error: unrecognized command line option ‘-fdiagnostics-color’

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[James Cheng[:JamesCheng]]

I met this error with the following condition.
My host compiler is < 4.9 and the target compiler is >= 4.9

I should remove 

http://searchfox.org/mozilla-central/rev/0c055ccbcf96846044fc9a71421bd9b7978686f7/build/moz.configure/toolchain.configure#896-900

to make it pass the compiling.

Comment 1

[Mike Hommey [:glandium]]

I think the easy way out here (as in, landable) is to remove HOST_CFLAGS/HOST_CXXFLAGS from https://dxr.mozilla.org/mozilla-central/rev/9b8bf5feb0b52aa4b03aa5fa3d4f0727b2974663/config/config.mk#357-358

We don't have much host code, and we can live with not having colors for them. Until we fix the asymmetry between host and target compilers in a global way.

Comment 2

[Mike Hommey [:glandium]]

(note that even funnier setups exist and work for android, where the target and host compilers are different compilers altogether (one being gcc and the other clang), and that are equally broken since the color flag for both compilers is different)

Comment 3

[Gregory Szorc [:gps]]

Attachment: Bug 1321750 - Remove automatic color flags from HOST_CFLAGS, HOST_CXXFLAGS;

moz.configure only sets the color flags value for the target compiler.
If the host compiler is a different version and doesn't support color
flags, we may pass unrecognized command line options.

Until we have better distinction between host and target compilers
in configure, just disable automatic color flags for host invocations.
We don't have too many host binaries, so this should have negligible
impact.

Review commit: https://reviewboard.mozilla.org/r/97234/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/97234/

Comment 4

[Mike Hommey [:glandium]]

Comment on attachment 8816504 [details]
Bug 1321750 - Remove automatic color flags from HOST_CFLAGS, HOST_CXXFLAGS;

https://reviewboard.mozilla.org/r/97234/#review97572

> Until we have better distinction between host and target compilers
> in configure

configure is actually the only place where host and target compilers are properly distinguished. The problem is the rest of the build system, including old-configure.

Comment 5

[Gregory Szorc [:gps]]

Comment on attachment 8816504 [details]
Bug 1321750 - Remove automatic color flags from HOST_CFLAGS, HOST_CXXFLAGS;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/97234/diff/1-2/

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a8e20bf36959
Remove automatic color flags from HOST_CFLAGS, HOST_CXXFLAGS; r=glandium

Comment 7

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/a8e20bf36959