timezone definition conflict since bug 1303091

RESOLVED FIXED in Firefox 52

Status

()

defect
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: gaston, Assigned: gaston)

Tracking

Trunk
mozilla53
Unspecified
OpenBSD
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox52 fixed, firefox53 fixed)

Details

Attachments

(1 attachment)

Build failure on OpenBSD, which has struct timezone in sys/time.h


35:58.02 In file included from /home/obj/m-c/js/src/Unified_cpp_js_src0.cpp:20:                                                            
35:58.04 /home/othersrc/mozilla-central/js/src/builtin/Intl.cpp:2171:39: error: reference to 'timezone' is ambiguous                       
35:58.06     for (const auto& legacyTimeZone : timezone::legacyICUTimeZones) {                                                             
35:58.08                                       ^                                                                                           
35:58.09 /usr/include/sys/time.h:72:8: note: candidate found by name lookup is 'timezone'                                                  
35:58.09 struct timezone {
35:58.09        ^
35:58.12 /home/othersrc/mozilla-central/js/src/builtin/IntlTimeZoneData.h:8:11: note: candidate found by name lookup is 'js::timezone'
35:58.12 namespace timezone {

prepending js:: namespace fixes the issue.
Blocks: 1303091
Posted patch bug-1321777Splinter Review
Assignee: nobody → landry
Attachment #8816420 - Flags: review?(andrebargull)
OS: Unspecified → OpenBSD
Version: 50 Branch → Trunk
Comment on attachment 8816420 [details] [diff] [review]
bug-1321777

Review of attachment 8816420 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for fixing!
Attachment #8816420 - Flags: review?(andrebargull) → review+
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c699b4675d34
Prepend js namespace to timezone to fix a build failure on OpenBSD. r=andrebargull
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/c699b4675d34
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
Comment on attachment 8816420 [details] [diff] [review]
bug-1321777

Approval Request Comment
[Feature/Bug causing the regression]: 1303091
[User impact if declined]: FTBFS on OpenBSD, see http://buildbot.rhaalovely.net/builders/mozilla-aurora-amd64/builds/1880
[Is this code covered by automated tests?]: ?
[Has the fix been verified in Nightly?]: Landed in https://hg.mozilla.org/mozilla-central/rev/c699b4675d34
[Needs manual test from QE? If yes, steps to reproduce]: no
[List of other uplifts needed for the feature/fix]: none
[Is the change risky?]: no
[Why is the change risky/not risky?]: uses explicit namespace
[String changes made/needed]: none
Attachment #8816420 - Flags: approval-mozilla-aurora?
Comment on attachment 8816420 [details] [diff] [review]
bug-1321777

openbsd build fix, take in aurora52
Attachment #8816420 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.