1321778 - Remove dead code that handles RC4 fallback

Status: RESOLVED FIXED

(Firefox :: Security, defect)

Description

[Masatoshi Kimura [:emk]]

+++ This bug was initially created as a clone of Bug #1130670 +++

I separated out the frontend change.

Comment 1

[Masatoshi Kimura [:emk]]

Attachment: Bug 1321778 - Remove vestigial RC4 fallback frontend.

Review commit: https://reviewboard.mozilla.org/r/97174/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/97174/

Comment 2

[Justin Dolske [:Dolske]]

Comment on attachment 8816421 [details]
Bug 1321778 - Remove vestigial RC4 fallback frontend.

https://reviewboard.mozilla.org/r/97174/#review111288

Sorry for taking so terribly long to get to this. :( I'm sure the patch has bitrotted a bit since posting; if you want review on an updated version I'll get to it quickly. (I suspect any updates will be trivial and not need re-review, though.)

::: browser/base/content/aboutNetError.xhtml:159
(Diff revision 1)
>          document.title = document.getElementById("certErrorPageTitle").textContent;
>          for (let host of document.querySelectorAll(".hostname")) {
>            host.textContent = document.location.hostname;
>          }
>  
> -        showAdvancedButton(true);
> +        showAdvancedButton();

There's also now a "setupAdvancedButton(true);" added to initPageCaptivePortal(), which is probably new since this patch. :/

::: browser/base/content/content.js
(Diff revision 1)
>        this.onPageLoad(aEvent);
>        break;
>      case "AboutNetErrorSetAutomatic":
>        this.onSetAutomatic(aEvent);
>        break;
> -    case "AboutNetErrorOverride":

Please remove the addEventListener("AboutNetErrorOverride") further up, too.

Comment 3

[Masatoshi Kimura [:emk]]

Comment on attachment 8816421 [details]
Bug 1321778 - Remove vestigial RC4 fallback frontend.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/97174/diff/1-2/

Comment 4

[Masatoshi Kimura [:emk]]

Comment on attachment 8816421 [details]
Bug 1321778 - Remove vestigial RC4 fallback frontend.

https://reviewboard.mozilla.org/r/97174/#review111288

> There's also now a "setupAdvancedButton(true);" added to initPageCaptivePortal(), which is probably new since this patch. :/

Apparently showAdvancedButton has been renamed to setupAdvancedButton. Fixed during rebase.

> Please remove the addEventListener("AboutNetErrorOverride") further up, too.

Done.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9b67e1ce3c80
Remove vestigial RC4 fallback frontend. r=Dolske

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/9b67e1ce3c80