13218 - [perf] ~5% of "new browser window" time spent compiling event handlers

Status: VERIFIED FIXED

(Core :: DOM: Events, defect, P3)

Description

[Chris Waterson]

A little over 5% of "browser: new window" time is spent compiling ~400 event
handlers. Since only a fraction of those are likely to ever fire, it'd be nice
to defer compilation until they're needed. This'll likely require changes to
the XUL DOM stuff; assigning to brendan for now.

Comment 1

[brendan-obsolete]

Looking at this now.

/be

Comment 2

[brendan-obsolete]

Need to clean up code copying in
http://bugzilla.mozilla.org/show_bug.cgi?id=9713 first.

/be

Comment 3

[Brendan Eich [:brendan]]

See 15146, which I'm making the master bug for this one, which should apply to
ducarroz's change.

/be

Comment 4

[Brendan Eich [:brendan]]

15146 is not the master of this domain!

/be

Comment 5

[Brendan Eich [:brendan]]

Vidur says he's doing the lazy compilation of event handlers part of this bug;
then for XUL, I'll do the compile-at-most-once and share from the prototype.

/be

Comment 6

[Brendan Eich [:brendan]]

Vidur's lazy compilation stuff is checked in.  I'll hack next.

/be

Comment 7

[Brendan Eich [:brendan]]

Attachment: proposed fix

Comment 8

[Brendan Eich [:brendan]]

Vidur and waterson reviewed, fix checked in.  Waterson'll prolly VERIFY when he
gets a chance to requantify.

/be

Comment 9

[Jan Carpenter]

Mass update of qa contact

Comment 10

[Vladimir Ermakov]

QA Contact Update

Comment 11

[Vladimir Ermakov]

verifying per developer's coments... cleaning

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6f5c56346bf6
[fenix] For https://github.com/mozilla-mobile/fenix/issues/13218: Fix settingsAddonsItemsTest
https://hg.mozilla.org/integration/autoland/rev/f6281acdc478
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/13218: adds IdlingResources for the Addons list