Closed
Bug 1321867
Opened 8 years ago
Closed 8 years ago
Permafailing Windows esr45 layout/base/tests/test_reftests_with_caret.html | reftest comparison: == http://mochi.test:8888/tests/layout/base/tests/bug602141-3.html http://mochi.test:8888/tests/layout/base/tests/bug602141-3-ref.html
Categories
(Core :: Layout, defect)
Core
Layout
Tracking
()
RESOLVED
WONTFIX
Tracking | Status | |
---|---|---|
firefox-esr45 | --- | disabled |
People
(Reporter: intermittent-bug-filer, Unassigned)
References
Details
(Keywords: intermittent-failure)
Comment 1•8 years ago
|
||
The failures show differences in focus outlines. This was apparently an issue in bug 881832 during the original development cycle, but I guess it just went away on its own? There was discussion about similar failures in that bug at one point, then died off.
Anyway, I'm strongly non-inclined to backout Matt's patchset from esr45 over this. But I'd also like to not disable test_reftests_with_caret.html if possible, so any thoughts about how we can work around this?
Comment 2•8 years ago
|
||
I seem to recall that those failures went away after Matt made
PresShell::DispatchSynthMouseMove do a recursive flush.
That change looks like it's also in esr45 though.
Matt probably remembers the details better than I do though,
since he debugged that bit with 'rr' and came up with the fix.
Fwiw, I compared the changesets that landed on esr45 for bug 881832
and its dependent bugs and they looked correct to me. The only
thing missing seems to be bug 1163212, but I see you're already
aware of that. I doubt that will fix this bug though. :-(
Comment 3•8 years ago
|
||
Maybe dbaron, who did the review, recalls the details about what fixed this test?
Flags: needinfo?(matt.woodrow)
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Matt, ping?
Comment hidden (Intermittent Failures Robot) |
Comment 10•8 years ago
|
||
I don't remember either sorry, I thought it was the DispatchSynthMouseMove change as well.
All the esr45 patches look like they were applied correctly, and I can't see anything obviously different in the impl of FlushPendingNotifications.
Flags: needinfo?(matt.woodrow)
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment 19•8 years ago
|
||
We're clearly not going to be fixing this.
https://hg.mozilla.org/releases/mozilla-esr45/rev/cc536e3e2ef4
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox-esr45:
--- → disabled
Resolution: --- → WONTFIX
Comment hidden (Intermittent Failures Robot) |
You need to log in
before you can comment on or make changes to this bug.
Description
•