image/Downscaler.h:158:59: warning: returning reference to temporary [-Wreturn-local-addr]

RESOLVED FIXED in Firefox 53

Status

()

Core
ImageLib
RESOLVED FIXED
7 months ago
7 months ago

People

(Reporter: tharvik, Assigned: tharvik)

Tracking

45 Branch
mozilla53
Points:
---

Firefox Tracking Flags

(firefox53 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

7 months ago
Created attachment 8816552 [details] [diff] [review]
Patch for the trunk version (works for 45, not tested for trunk)

User Agent: Mozilla/5.0 (X11; Linux i686) AppleWebKit/538.15+ (KHTML, like Gecko) vimb/2.11 Version/8.0 Safari/538.15

Steps to reproduce:

On Gentoo `emerge =www-client/firefox-45.5.0`
Compiling the codebase with gcc and `-Wreturn-local-addr` (default on).


Actual results:

image/Downscaler.h:158:59: warning: returning reference to temporary [-Wreturn-local-addr]
image/Downscaler.h:159:57: warning: returning reference to temporary [-Wreturn-local-addr]
image/Downscaler.h:160:48: warning: returning reference to temporary [-Wreturn-local-addr]



Expected results:

No warnings
Component: Untriaged → ImageLib
Product: Firefox → Core
Attachment #8816552 - Attachment is patch: true
Attachment #8816552 - Attachment mime type: text/x-patch → text/plain
Comment on attachment 8816552 [details] [diff] [review]
Patch for the trunk version (works for 45, not tested for trunk)

You may as well initialize mSize as well.
(Assignee)

Comment 2

7 months ago
(In reply to Timothy Nikkel (:tnikkel) from comment #1)
> Comment on attachment 8816552 [details] [diff] [review]
> Patch for the trunk version (works for 45, not tested for trunk)
> 
> You may as well initialize mSize as well.
The default constructor would get called, if I'm correct.
Attachment #8816552 - Flags: review+
Assignee: nobody → tharvik
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
(Assignee)

Comment 3

7 months ago
@:tnikkel, I'm supposed to ask you "to push it to the try server for testing", as I don't have any push access.
Flags: needinfo?(tnikkel)
https://treeherder.mozilla.org/#/jobs?repo=try&revision=dad797ebc115350cfd14a63ef9411d9daf9d5d4e
Flags: needinfo?(tnikkel)

Comment 5

7 months ago
Pushed by tnikkel@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5cebfb1902a2
Fix compiler warnings in Downscaler.h when skia is not enabled. r=tnikkel

Comment 6

7 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/5cebfb1902a2
Status: ASSIGNED → RESOLVED
Last Resolved: 7 months ago
status-firefox53: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
You need to log in before you can comment on or make changes to this bug.