If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Get rid of IsCallerChrome usage in DOM animations code

RESOLVED FIXED in Firefox 53

Status

()

Core
DOM: Animation
RESOLVED FIXED
11 months ago
10 months ago

People

(Reporter: bz, Assigned: bz)

Tracking

(Blocks: 1 bug)

Trunk
mozilla53
Points:
---

Firefox Tracking Flags

(firefox53 fixed)

Details

Attachments

(3 attachments)

Comment hidden (empty)
Created attachment 8816557 [details] [diff] [review]
part 1.  Add an API on GlobalObject to get the caller type, for use in things like WebIDL constructors
Attachment #8816557 - Flags: review?(bobbyholley)
Created attachment 8816559 [details] [diff] [review]
part 2.  Stop using IsCallerChrome() in animations API
Attachment #8816559 - Flags: review?(bbirtles)
Attachment #8816557 - Flags: review?(bobbyholley) → review+

Updated

11 months ago
Attachment #8816559 - Flags: review?(bbirtles) → review+

Comment 3

11 months ago
Created attachment 8816720 [details] [diff] [review]
part 2. Stop using IsCallerChrome() in animations API (rebased on bug 1305325)

Hello bz, could you please wait for landing patches of this bug until bug 1305325 is merged into inbound?

I will land patches in bug 1305325 to autoland, one of the patches will conflict this part 2 patch on mozilla-central if you are going to land to inbound.

This is the rebased patch of the part 2.  I am sorry for the inconvenience.
Flags: needinfo?(bzbarsky)
I can do that, sure.  Thank you for posting the merged patch!

Comment 5

10 months ago
Pushed by bzbarsky@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/29e59ce35d70
part 1.  Add an API on GlobalObject to get the caller type, for use in things like WebIDL constructors.  r=bholley
https://hg.mozilla.org/integration/mozilla-inbound/rev/c0c3a434a0b2
part 2.  Stop using IsCallerChrome() in animations API.  r=birtles

Comment 6

10 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/29e59ce35d70
https://hg.mozilla.org/mozilla-central/rev/c0c3a434a0b2
Status: NEW → RESOLVED
Last Resolved: 10 months ago
status-firefox53: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
Flags: needinfo?(bzbarsky)
You need to log in before you can comment on or make changes to this bug.