1321909 - Remove the "security.ssl.false_start.require-npn" pref

Status: RESOLVED FIXED

(Core :: Security: PSM, defect, P1)

Description

[Masatoshi Kimura [:emk]]

This pref is disabled by default for a long time. Although this pref also considers ALPN contrary to the name, I don't think we still need this. People can disable False Start itself in case they encountered hangs.

Comment 1

[Masatoshi Kimura [:emk]]

Attachment: Bug 1321909 - Remove the "security.ssl.false_start.require-npn" pref.

Review commit: https://reviewboard.mozilla.org/r/97302/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/97302/

Comment 2

[Masatoshi Kimura [:emk]]

Comment on attachment 8816633 [details]
Bug 1321909 - Remove the "security.ssl.false_start.require-npn" pref.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/97302/diff/1-2/

Comment 3

[Dana Keeler (she/her) (use needinfo) [:keeler] (on leave)]

Just as a heads-up, I'm at a conference this week. I probably won't be able to review this until next week.

Comment 4

[Masatoshi Kimura [:emk]]

Yeah, I forgot about all hands. Have fun!

Comment 5

[Dana Keeler (she/her) (use needinfo) [:keeler] (on leave)]

Comment on attachment 8816633 [details]
Bug 1321909 - Remove the "security.ssl.false_start.require-npn" pref.

https://reviewboard.mozilla.org/r/97302/#review98366

Code-wise, this looks good. Telemetry also indicates this shouldn't be an issue. I think it would be prudent to get another opinion on the policy change, though, so I'll need-info :mt for that.

Comment 6

[Dana Keeler (she/her) (use needinfo) [:keeler] (on leave)]

:mt, I just wanted to double-check that this is a reasonable change.

Comment 7

[Martin Thomson [:mt:]]

Yes, we should remove this.  It's cruft.

Flipping this switch will likely have the effect of disabling false start, which we can do in more direct ways.  It might not actually disable NPN if the server supports ALPN, but we don't want to rely on that.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e728e6be59dc
Remove the "security.ssl.false_start.require-npn" pref. r=keeler

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/e728e6be59dc