Remove the "security.ssl.false_start.require-npn" pref

RESOLVED FIXED in Firefox 53

Status

()

Core
Security: PSM
P1
normal
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: emk, Assigned: emk)

Tracking

unspecified
mozilla53
Points:
---

Firefox Tracking Flags

(firefox53 fixed)

Details

(Whiteboard: [psm-assigned])

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
This pref is disabled by default for a long time. Although this pref also considers ALPN contrary to the name, I don't think we still need this. People can disable False Start itself in case they encountered hangs.
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Just as a heads-up, I'm at a conference this week. I probably won't be able to review this until next week.
(Assignee)

Comment 4

2 years ago
Yeah, I forgot about all hands. Have fun!

Comment 5

2 years ago
mozreview-review
Comment on attachment 8816633 [details]
Bug 1321909 - Remove the "security.ssl.false_start.require-npn" pref.

https://reviewboard.mozilla.org/r/97302/#review98366

Code-wise, this looks good. Telemetry also indicates this shouldn't be an issue. I think it would be prudent to get another opinion on the policy change, though, so I'll need-info :mt for that.
Attachment #8816633 - Flags: review?(dkeeler) → review+
:mt, I just wanted to double-check that this is a reasonable change.
Flags: needinfo?(martin.thomson)
Assignee: nobody → VYV03354
Priority: -- → P1
Whiteboard: [psm-assigned]
Yes, we should remove this.  It's cruft.

Flipping this switch will likely have the effect of disabling false start, which we can do in more direct ways.  It might not actually disable NPN if the server supports ALPN, but we don't want to rely on that.
Flags: needinfo?(martin.thomson)

Comment 8

2 years ago
Pushed by VYV03354@nifty.ne.jp:
https://hg.mozilla.org/integration/autoland/rev/e728e6be59dc
Remove the "security.ssl.false_start.require-npn" pref. r=keeler

Comment 9

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/e728e6be59dc
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox53: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
You need to log in before you can comment on or make changes to this bug.