1321910 - Error: $scope.currentRepo is undefined in $scope.backfillButtonTitle

Status: RESOLVED FIXED

(Tree Management :: Treeherder, defect, P1)

Description

[Ed Morley [:emorley]]

On initial pageload of https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound the console gets spammed with lots of:

Error: $scope.currentRepo is undefined
$scope.backfillButtonTitle@https://treeherder.mozilla.org/js/index.min.d9fa7158a9bd2aa7.js:29:14595
<SNIP>

Regression from bug 1207460?

Comment 1

[Jonathan French (:jfrench)]

Yes, I think it would have to be, that commit added that scope variable. I'm having a look.

Comment 2

[Jonathan French (:jfrench)]

I think backfillButtonTitle() is asking for $scope.currentRepo before it exists during page load.

I related function we always had, canBackFill(), appears to experience similar behavior when I put a print in it. It's undefined for a short while during page load (you see a bunch of undefined fly by the console) then it exists and the currentRepo object(s) print out fine. However canBackFill() is used as part of a t/f test for classes and the disabled state, not a title string.

I had just borrowed that same currentRepo test for backfillButtonTitle() assuming it was always 'there'.

Noting here also, I don't think my ng-attr-title was necessary either, I think it could just be title.

Still having a look.

Comment 3

[Jonathan French (:jfrench)]

(In reply to Jonathan French (:jfrench) from comment #2)
> I related function we always had

s/I related/A related/

Comment 4

[GitHub Autolander Bot]

Attachment: [treeherder] tojon:fix-backfill-btntitle > mozilla:master

Comment 5

[Jonathan French (:jfrench)]

Well, I have a fix up. Whether it's the correct and best way, is a separate question. :) If you need to tweak it further and merge it asap, feel free. Otherwise I'll keep an eye for review comments.

Comment 6

[Jonathan French (:jfrench)]

Comment on attachment 8816636 [details] [review]
[treeherder] tojon:fix-backfill-btntitle > mozilla:master

Ed, if you wish to re-assign the review flag to :camd or :wlach feel free. :) I'm unsure who is around prior to work week travel.

Comment 7

[William Lachance (:wlach)]

Comment on attachment 8816636 [details] [review]
[treeherder] tojon:fix-backfill-btntitle > mozilla:master

Hey Jon! Thanks for this. I have a few requests for changes before landing.

Comment 8

[Jonathan French (:jfrench)]

Comment on attachment 8816636 [details] [review]
[treeherder] tojon:fix-backfill-btntitle > mozilla:master

Yup, that change works fine. I've re-pushed.

Comment 9

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/ae3b1052a95a1c431d52b1025bb75ae5bf2c28cd
Bug 1321910 - Fix backfill title console error on page load (#2018)

Comment 10

[William Lachance (:wlach)]

I think we can resolve this now.