132204 - nsIFrame::AddCSSMaxSize returns wrong boolean

Status: NEW

(Core :: Layout, defect, P3)

Description

[Boris Zbarsky [:bzbarsky]]

nsIBox::AddCSSMaxSize returns (widthSet || heightSet)

Both nsIBox::AddCSSMinSize and nsIBox::AddCSSPrefSize return 
(widthSet && heightSet) and based on the code at
http://lxr.mozilla.org/seamonkey/source/layout/xul/base/src/nsContainerBox.cpp#559
the MinSize/PrefSize return value seems to be correct....

Comment 1

[Christine Hoffman]

Changing QA contact

Comment 2

[mjh563]

Attachment: testcase

This testcase demonstrates incorrect layout caused by this bug.

Is it worth fixing though, given that the bug has existed for so long? It could potentially break content that depends on the buggy implementation.

Comment 3

[mjh563]

Note that current versions of Firefox will not open the testcase by default. You'll need to do one of the following:

1. Set |dom.allow_XUL_XBL_for_file| to true, then save the testcase to disk and open it as a file, or

2. Install https://addons.mozilla.org/en-US/firefox/addon/remote-xul-manager/ and add bugzilla.mozilla.org to the remote XUL whitelist.

Comment 4

[mjh563]

Attachment: patch

Comment 5

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 785438 [details] [diff] [review]
patch

r=me I guess, but I too wonder whether it's worth messing with this...