1322067 - Starring a failure isn't reflected in other tabs (or in other people's tabs) without refreshing the entire page

Status: RESOLVED FIXED

(Tree Management :: Treeherder, defect)

Description

[Phil Ringnalda (:philor)]

Not quite sure what part is failing, but we appear to be fetching, e.g., https://treeherder.mozilla.org/api/project/mozilla-inbound/jobs/?count=2000&last_modified__gt=2016-12-04T19:58:06.944&result_set_id__in=150498,150496&return_type=list to update results, and only rarely actually showing that some other tab, or window, or browser on another person's computer on another continent, has starred something.

STR:

1. Open https://treeherder.allizom.org/#/jobs?repo=mozilla-inbound in two tabs and note the unstarred count
2. Star something in one tab

Expected: after whatever the refresh interval is, both tabs will have the new unstarred count of one less than before, and both tabs will show the job you starred as starred

Actual: no matter how long you wait, unless the job you starred was (unknown, something related to having just finished or to how quickly you star after the initial load of the two tabs), the count and starred state in the other tab, the one where you didn't star it, will remain unchanged.

Best wild guess: starring doesn't actually affect last_modified__gt, and we load initial results differently than we load them on the periodic refresh and maybe don't do last_modified__gt on the first periodic refresh, so the one time when I was able to get starring to show up in another tab, by waiting for a failure to appear, then opening another tab and immediately going back to the first tab and starring it, what I was seeing was that the only starring by other tabs or other people which will show up is what happens between the time you initially load treeherder and the time of the first periodic refresh.

Comment 1

[William Lachance (:wlach)]

Possibly a regression from bug 1318474, I'll need to look into this.

Comment 2

[GitHub Autolander Bot]

Attachment: [treeherder] wlach:1322067 > mozilla:master

Comment 3

[William Lachance (:wlach)]

Comment on attachment 8817208 [details] [review]
[treeherder] wlach:1322067 > mozilla:master

I think this should fix it, sorry for the inconvenience.

Comment 4

[Cameron Dawson [:camd]]

Comment on attachment 8817208 [details] [review]
[treeherder] wlach:1322067 > mozilla:master

I didn't test this, but I'll trust that you did.  :)  Looks good to me.  Thanks to Ed for doing a pre-review as well.  :)

Comment 5

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/78f4229f313a83dbc20c4d23ff00134ca310e0bb
Bug 1322067 - Update `last_modified` when job is starred or cancelled (#2021)

Comment 6

[William Lachance (:wlach)]

I think we should be good now.

Comment 7

[William Lachance (:wlach)]

(this will need to get deployed to production before users will see the fix, of course)