Closed
Bug 1322072
Opened 8 years ago
Closed 8 years ago
Port glue-dependent mailnews tests to gtest
Categories
(MailNews Core :: Testing Infrastructure, defect)
MailNews Core
Testing Infrastructure
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 53.0
People
(Reporter: aleth, Assigned: aleth)
References
(Depends on 1 open bug)
Details
Attachments
(2 files, 1 obsolete file)
15.02 KB,
patch
|
jorgk-bmo
:
review+
|
Details | Diff | Splinter Review |
1.13 KB,
patch
|
benjamin
:
review+
|
Details | Diff | Splinter Review |
Something similar to Bug 1313752 should work here too.
Assignee | ||
Comment 1•8 years ago
|
||
This should work... in principle. However, cppunittests aren't running in automation for TB, and neither are gtests. If that's the case, and nobody's been running this test for ages, maybe we should just stop building it?
Attachment #8816823 -
Flags: feedback?(philipp)
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → aleth
Status: NEW → ASSIGNED
Assignee | ||
Comment 2•8 years ago
|
||
Assignee | ||
Comment 3•8 years ago
|
||
Assignee | ||
Comment 4•8 years ago
|
||
Comment on attachment 8816823 [details] [diff] [review]
Port TestMailCookie to gtest
Review of attachment 8816823 [details] [diff] [review]:
-----------------------------------------------------------------
Let's take this for now and we can reenable the test at a later stage.
Attachment #8816823 -
Flags: feedback?(philipp) → review?(philipp)
Assignee | ||
Comment 5•8 years ago
|
||
Attachment #8825556 -
Flags: review?(benjamin)
Assignee | ||
Updated•8 years ago
|
Attachment #8816824 -
Attachment is obsolete: true
Updated•8 years ago
|
Attachment #8825556 -
Flags: review?(benjamin) → review+
Comment 6•8 years ago
|
||
https://hg.mozilla.org/comm-central/rev/89cfdf12b27260e9e6a8ed14b4c41066c1a1cc0c
Sorry, I had to rs this to fix immediate bustage.
Updated•8 years ago
|
Attachment #8816823 -
Flags: review?(philipp) → review+
Comment 7•8 years ago
|
||
Aleth, can you please do what's left to do here, like get the M-C part landed.
Flags: needinfo?(aleth)
Assignee | ||
Comment 8•8 years ago
|
||
(In reply to Jorg K (GMT+1) from comment #7)
> Aleth, can you please do what's left to do here, like get the M-C part
> landed.
The m-c part would have been required if this had landed before the XPCOM glue removal. Now it's gone, there's no exceptions any more...
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Flags: needinfo?(aleth)
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 53.0
You need to log in
before you can comment on or make changes to this bug.
Description
•