1322185 - stylo: support remaining display property values

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Cameron McCormack (:heycam)]

We don't support a bunch of display property values yet.

Comment 1

[Cameron McCormack (:heycam)]

Attachment: Bug 1322185 - Rename some StyleDisplay enum values for consistency.

Review commit: https://reviewboard.mozilla.org/r/97422/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/97422/

Comment 2

[Cameron McCormack (:heycam)]

Attachment: Support declaring keyword property Gecko coverage as inexhaustive.

This allows us to control whether the catchall case in the match expression
that maps Gecko const to Servo enum will be generated.

Review commit: https://reviewboard.mozilla.org/r/97424/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/97424/

Comment 3

[Cameron McCormack (:heycam)]

Attachment: Regenerate bindings.

Review commit: https://reviewboard.mozilla.org/r/97426/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/97426/

Comment 4

[Cameron McCormack (:heycam)]

Attachment: stylo: Support remaining display property values.

Review commit: https://reviewboard.mozilla.org/r/97428/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/97428/

Comment 5

[Cameron McCormack (:heycam)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=8fc05c0706875288706fee2f59b7bd0bffc7de06

Comment 6

[Xidorn Quan [:xidorn] UTC+10]

Comment on attachment 8816941 [details]
Bug 1322185 - Rename some StyleDisplay enum values for consistency.

https://reviewboard.mozilla.org/r/97422/#review97720

Comment 7

[Manish Goregaokar [:manishearth]]

Comment on attachment 8816942 [details]
Support declaring keyword property Gecko coverage as inexhaustive.

https://reviewboard.mozilla.org/r/97424/#review97728

::: servo/components/style/properties/longhand/border.mako.rs:61
(Diff revision 1)
>                                animatable=True)}
>  % endfor
>  
>  ${helpers.single_keyword("box-decoration-break", "slice clone",
>                           gecko_enum_prefix="StyleBoxDecorationBreak",
> +                         gecko_inexhaustive=true,

capital True.

Lowercase true works (welcome to python!), but we shouldn't use it.

Comment 8

[Manish Goregaokar [:manishearth]]

Comment on attachment 8816943 [details]
Regenerate bindings.

https://reviewboard.mozilla.org/r/97426/#review97730

Comment 9

[Manish Goregaokar [:manishearth]]

Comment on attachment 8816944 [details]
stylo: Support remaining display property values.

https://reviewboard.mozilla.org/r/97428/#review97732

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/46c2e215ec34
Rename some StyleDisplay enum values for consistency. r=xidorn

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/46c2e215ec34