stylo: support remaining display property values

RESOLVED FIXED in Firefox 53

Status

()

defect
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: heycam, Unassigned)

Tracking

unspecified
mozilla53
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox53 fixed)

Details

Attachments

(4 attachments)

We don't support a bunch of display property values yet.
Attachment #8816942 - Flags: review?(manishearth)
Attachment #8816943 - Flags: review?(manishearth)
Attachment #8816944 - Flags: review?(manishearth)
Comment on attachment 8816941 [details]
Bug 1322185 - Rename some StyleDisplay enum values for consistency.

https://reviewboard.mozilla.org/r/97422/#review97720
Attachment #8816941 - Flags: review?(xidorn+moz) → review+
Comment on attachment 8816942 [details]
Support declaring keyword property Gecko coverage as inexhaustive.

https://reviewboard.mozilla.org/r/97424/#review97728

::: servo/components/style/properties/longhand/border.mako.rs:61
(Diff revision 1)
>                                animatable=True)}
>  % endfor
>  
>  ${helpers.single_keyword("box-decoration-break", "slice clone",
>                           gecko_enum_prefix="StyleBoxDecorationBreak",
> +                         gecko_inexhaustive=true,

capital True.

Lowercase true works (welcome to python!), but we shouldn't use it.
Attachment #8816942 - Flags: review?(manishearth) → review+
Comment on attachment 8816943 [details]
Regenerate bindings.

https://reviewboard.mozilla.org/r/97426/#review97730
Attachment #8816943 - Flags: review?(manishearth) → review+
Comment on attachment 8816944 [details]
stylo: Support remaining display property values.

https://reviewboard.mozilla.org/r/97428/#review97732
Attachment #8816944 - Flags: review?(manishearth) → review+
Pushed by cmccormack@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/46c2e215ec34
Rename some StyleDisplay enum values for consistency. r=xidorn
https://hg.mozilla.org/mozilla-central/rev/46c2e215ec34
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
You need to log in before you can comment on or make changes to this bug.