Frequent intermittent gtest TEST-UNEXPECTED-FAIL | gtest | timed out after 1200 seconds running TestNamedPipeService after landing of bug 1313752

RESOLVED FIXED in Firefox 53

Status

()

Core
Networking
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: Benjamin Smedberg, Assigned: Benjamin Smedberg)

Tracking

(Blocks: 1 bug, {intermittent-failure})

unspecified
mozilla53
intermittent-failure
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox51 unaffected, firefox52 unaffected, firefox53 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
Split off from the more generic bug 1115253: after the conversion of TestNamedPipeService to gtest, there are rather frequent timeouts running this test.
 
Please only star timeouts in this test to this bug. Other timeouts should stay with the original bug.

I'm going to investigate. gtests don't appear to print assertion success, so I don't yet know where this is hanging, but I think a little logging will narrow this down.
Comment hidden (mozreview-request)
(Assignee)

Updated

2 years ago
Attachment #8817429 - Flags: review?(daniel)
Comment on attachment 8817429 [details]
Bug 1322377 - frequent intermittent timeouts in TestNamedPipeService - there was a race between notifying the monitor and waiting for it, so instead of a monitor use an event,

https://reviewboard.mozilla.org/r/97702/#review98054

LGTM! (note that my nick is actually 'bagder', a misspelled version of the animal)
Attachment #8817429 - Flags: review?(daniel) → review+

Comment 4

2 years ago
Pushed by bsmedberg@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/28d3c72eaecd
frequent intermittent timeouts in TestNamedPipeService - there was a race between notifying the monitor and waiting for it, so instead of a monitor use an event, r=bagder

Comment 5

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/28d3c72eaecd
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox53: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
status-firefox51: --- → unaffected
status-firefox52: --- → unaffected
You need to log in before you can comment on or make changes to this bug.