1322377 - Frequent intermittent gtest TEST-UNEXPECTED-FAIL | gtest | timed out after 1200 seconds running TestNamedPipeService after landing of bug 1313752

Status: RESOLVED FIXED

(Core :: Networking, defect)

Description

[Benjamin Smedberg]

Split off from the more generic bug 1115253: after the conversion of TestNamedPipeService to gtest, there are rather frequent timeouts running this test.
 
Please only star timeouts in this test to this bug. Other timeouts should stay with the original bug.

I'm going to investigate. gtests don't appear to print assertion success, so I don't yet know where this is hanging, but I think a little logging will narrow this down.

Comment 1

[Benjamin Smedberg]

Example: https://treeherder.mozilla.org/logviewer.html#?repo=mozilla-inbound&job_id=40225283#L7726

Comment 2

[Benjamin Smedberg]

Attachment: Bug 1322377 - frequent intermittent timeouts in TestNamedPipeService - there was a race between notifying the monitor and waiting for it, so instead of a monitor use an event,

Review commit: https://reviewboard.mozilla.org/r/97702/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/97702/

Comment 3

[Daniel Stenberg [:bagder]]

Comment on attachment 8817429 [details]
Bug 1322377 - frequent intermittent timeouts in TestNamedPipeService - there was a race between notifying the monitor and waiting for it, so instead of a monitor use an event,

https://reviewboard.mozilla.org/r/97702/#review98054

LGTM! (note that my nick is actually 'bagder', a misspelled version of the animal)

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/28d3c72eaecd
frequent intermittent timeouts in TestNamedPipeService - there was a race between notifying the monitor and waiting for it, so instead of a monitor use an event, r=bagder

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/28d3c72eaecd