Closed Bug 1322377 Opened 3 years ago Closed 3 years ago

Frequent intermittent gtest TEST-UNEXPECTED-FAIL | gtest | timed out after 1200 seconds running TestNamedPipeService after landing of bug 1313752

Categories

(Core :: Networking, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla53
Tracking Status
firefox51 --- unaffected
firefox52 --- unaffected
firefox53 --- fixed

People

(Reporter: benjamin, Assigned: benjamin)

References

(Blocks 1 open bug)

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

Split off from the more generic bug 1115253: after the conversion of TestNamedPipeService to gtest, there are rather frequent timeouts running this test.
 
Please only star timeouts in this test to this bug. Other timeouts should stay with the original bug.

I'm going to investigate. gtests don't appear to print assertion success, so I don't yet know where this is hanging, but I think a little logging will narrow this down.
Attachment #8817429 - Flags: review?(daniel)
Comment on attachment 8817429 [details]
Bug 1322377 - frequent intermittent timeouts in TestNamedPipeService - there was a race between notifying the monitor and waiting for it, so instead of a monitor use an event,

https://reviewboard.mozilla.org/r/97702/#review98054

LGTM! (note that my nick is actually 'bagder', a misspelled version of the animal)
Attachment #8817429 - Flags: review?(daniel) → review+
Pushed by bsmedberg@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/28d3c72eaecd
frequent intermittent timeouts in TestNamedPipeService - there was a race between notifying the monitor and waiting for it, so instead of a monitor use an event, r=bagder
https://hg.mozilla.org/mozilla-central/rev/28d3c72eaecd
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
You need to log in before you can comment on or make changes to this bug.