1322462 - Fix NAN expression errors that clang plugin reports on Windows

Status: RESOLVED FIXED

(Developer Infrastructure :: Source Code Analysis, defect)

Comment 1

[Ting-Yu Chou [:ting] (away)]

Attachment: wip

Comment 2

[Ting-Yu Chou [:ting] (away)]

The error message:

68:07.96 c:/w/fx/mc/gfx/angle/src/libANGLE/State.cpp(505,39):  error(clang): comparing a floating point value to itself for NaN checking can lead to incorrect results
68:07.99     mRasterizer.polygonOffsetFactor = factor != factor ? 0.0f : factor;
68:08.01                                       ^
68:08.01 c:/w/fx/mc/gfx/angle/src/libANGLE/State.cpp(505,39):  note(clang): consider using mozilla::IsNaN instead
68:08.01 c:/w/fx/mc/gfx/angle/src/libANGLE/State.cpp(506,38):  error(clang): comparing a floating point value to itself for NaN checking can lead to incorrect results
68:08.03     mRasterizer.polygonOffsetUnits = units != units ? 0.0f : units;
68:08.04                                      ^
68:08.04 c:/w/fx/mc/gfx/angle/src/libANGLE/State.cpp(506,38):  note(clang): consider using mozilla::IsNaN instead
68:08.04 2 errors generated.

Comment 3

[Ting-Yu Chou [:ting] (away)]

Attachment: Bug 1322462 - Ignore the is-NAN testings in libANGLE that clang plugin reports on Windows.

Review commit: https://reviewboard.mozilla.org/r/97672/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/97672/

Comment 4

[(no longer active)]

Comment on attachment 8817376 [details]
Bug 1322462 - Ignore the is-NAN testings in libANGLE that clang plugin reports on Windows.

https://reviewboard.mozilla.org/r/97672/#review98032

Comment 5

[Nathan Froyd [:froydnj]]

angle is third-party code, right?  So we shouldn't be modifying it?

Comment 6

[(no longer active)]

Yeah... I mean, we _could_, but the angle people are terrible at taking patches.  I have had patches waiting for their review for months, and every time I need to hunt down a gfx person who's in touch with them to get them to look at my patch.  It's not worth it here IMO.

(The SkScalar.h header is also there for similar reasons.)

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4ee89b6c76d7
Ignore the is-NAN testings in libANGLE that clang plugin reports on Windows. r=Ehsan

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/4ee89b6c76d7