1322521 - Show a label on highlights that appear from another device indicating that it came from another device

Status: NEW

(Firefox for iOS :: General, defect, P3)

Description

[Stephan Leroux [:sleroux]]

Instead of showing 'Visited' or 'Bookmarked' in the bottom corner, we want to display some kind of label to indicate that the highlight was made available by another device through sync. 

Couple of points to clarify:

1. Is this the 'Open Tab' label/image we have in some of the mockups
2. Do we want to display the device name where a highlight came from?
3. Do we simply want to say that this highlight was generated from a 'Remote Visit'? (Probably the easiest to do)

Comment 1

[Bryan Munar (:bkmunar)]

Is this something we want? I don't remember seeing a discussion about this

Comment 2

[Barbara Bermes [:barbara] - NI please!]

I can't seemed to find this on the MVP roadmap trello board, however it would be very beneficial to include it.

#3 sound good to me, unless bbell doesn't like it :)

Comment 3

[Barbara Bermes [:barbara] - NI please!]

just chatted with Sebastian, there is nothing for MVP for Android that is similar to this. 

re: #3, Steph, how would this technically work? What would decide that a remote visit shows up? 

I'm fine with passing on with this and not having it in MVP until we've clarified the behaviour/algorithms.

As for #1, could you share the mocks with me?

Comment 4

[Stephan Leroux [:sleroux]]

Attachment: https://mozilla.invisionapp.com/share/PQ87C8MV7#/screens/178815181

> I can't seemed to find this on the MVP roadmap trello board, however it would be very beneficial to include it.

This would be the closest card (I think) but it's unclear if this story includes this feature:

https://trello.com/c/s0oy96Zn/41-highlights-i-want-to-continue-browsing-and-exploring-highlights-items-no-matter-what-device-i-open-firefox-on

I've attached the a screentshot of the 'Open Tab' highlight cell from this invision mockup:

https://mozilla.invisionapp.com/share/PQ87C8MV7#/screens/178815181

> re: #3, Steph, how would this technically work? What would decide that a remote visit shows up? 

On iOS we have a Visits table that tells us if a visit was done locally or remotely. We could factor that into the SQL query we make to generate highlights to surface a is_remote flag. Unfortunately I don't think we have a way to link a remote visit to a particular synced device so the best we can do is just say 'Remote Visit' instead of 'Visited on Desktop-123'.

Either way I'm totally fine excluding this from the MVP since IMO it doesn't add much value anyways.

I would however like clarification as to exact which tags we want to display on the highlights. The mock up shows tags for 'Reading List', 'Bookmarked' and 'Open Tab'. Unfortunately I can't find the mock up that showed 'Remote Visit' or 'Recently Visited' on the highlights row right now but I'm sure I've seen those used before. I'd like to know the canonical list of tags we want to show and when they should be shown.

Maybe Android already has this implemented?