Use a different icon in captive portal error page

RESOLVED FIXED in Firefox 52

Status

()

Firefox
General
RESOLVED FIXED
5 months ago
3 months ago

People

(Reporter: nhnt11, Assigned: nhnt11)

Tracking

Trunk
Firefox 53
Points:
---

Firefox Tracking Flags

(firefox52 fixed, firefox53 fixed)

Details

(Whiteboard: [fxprivacy])

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(2 attachments)

(Assignee)

Description

5 months ago
A small, relatively easy improvement to the captive portal experience is to show a more relevant icon in the error page (once bug 989197 lands). For example, Philipp suggested we show a "WiFi" icon instead.

To be clear: this is instead of the "info" icon (i with a circle around it).
(Assignee)

Updated

5 months ago
Flags: needinfo?(philipp)
Created attachment 8820312 [details]
wifi.svg

Here's the icon! Let me know if that works.
Flags: needinfo?(philipp)
Comment hidden (mozreview-request)
(Assignee)

Updated

4 months ago
Attachment #8824748 - Flags: review?(MattN+bmo) → review?(gijskruitbosch+bugs)
(Assignee)

Updated

4 months ago
Assignee: nobody → nhnt11
Status: NEW → ASSIGNED
Comment on attachment 8824748 [details]
Bug 1322531 - Use a different icon in captive portal error page.

https://reviewboard.mozilla.org/r/103070/#review103700

I didn't test this but patch but it looks fine to me.
Attachment #8824748 - Flags: review+
Comment on attachment 8824748 [details]
Bug 1322531 - Use a different icon in captive portal error page.

https://reviewboard.mozilla.org/r/103070/#review103812

r=me but please tidy up the SVG.

::: browser/themes/shared/incontent-icons/wifi.svg:1
(Diff revision 1)
> +<?xml version="1.0" encoding="utf-8"?>

Please see https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/SVG_Guidelines .

You will need a license, and you should omit the xlink namespace as it's unused.

The width/height/viewbox is also confusing and look wrong.

cls-1 seems unnecessary, and cls-3 I expect can be an attribute. Please rename cls-2 to something more meaningful.
Attachment #8824748 - Flags: review?(gijskruitbosch+bugs) → review+
Comment hidden (mozreview-request)

Comment 6

4 months ago
Pushed by nhnt11@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/e054b0a0e5f7
Use a different icon in captive portal error page. r=Gijs,MattN

Comment 7

4 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/e054b0a0e5f7
Status: ASSIGNED → RESOLVED
Last Resolved: 4 months ago
status-firefox53: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 53
(Assignee)

Comment 8

4 months ago
Comment on attachment 8824748 [details]
Bug 1322531 - Use a different icon in captive portal error page.

Approval Request Comment
[User impact if declined]: This patch makes the icon shown in the captive portal error page more relevant.
[Is this code covered by automated tests?]: no
[Has the fix been verified in Nightly?]: yes
[Needs manual test from QE? If yes, steps to reproduce]: no
[List of other uplifts needed for the feature/fix]:
[Is the change risky?]: no, just an icon change
[Why is the change risky/not risky?]:
[String changes made/needed]:
Attachment #8824748 - Flags: approval-mozilla-aurora?

Updated

3 months ago
Iteration: --- → 53.5 - Jan 23
Comment on attachment 8824748 [details]
Bug 1322531 - Use a different icon in captive portal error page.

new icon for captive portal error page, aurora52+
Attachment #8824748 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+

Comment 10

3 months ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-aurora/rev/d387b2aa3dc2
status-firefox52: --- → fixed
You need to log in before you can comment on or make changes to this bug.