1322569 - Support about:reader on OriginParser

Status: RESOLVED FIXED

(Core :: Storage: Quota Manager, defect, P2)

Description

[Myk Melez [:myk] [@mykmelez]]

On my regular profile, with the latest Nightly, all attempts to load a service worker script are failing with:

  Registration failed: TypeError: ServiceWorker script at SW-URL for scope
  SCOPE-URL encountered an error during installation.

This might be related to bug 1242056, except that I'm on the latest Nightly, whereas that bug is an issue when using a Release version of Firefox with a profile that was previously used with the latest Nightly.

Example: https://new.cleopatra.io/

"TypeError: ServiceWorker script at https://new.cleopatra.io/sw.js for scope https://new.cleopatra.io/ encountered an error during installation."

Comment 1

[Ben Kelly [:bkelly, not reviewing]]

Does this happen on a fresh profile?

Comment 2

[Myk Melez [:myk] [@mykmelez]]

(In reply to Ben Kelly [:bkelly] from comment #1)
> Does this happen on a fresh profile?

No, I can't reproduce on a fresh profile.

Comment 3

[Myk Melez [:myk] [@mykmelez]]

Ben: is there a particular subset of the failing profile that I can provide to help diagnose the problem?

Comment 4

[Ben Kelly [:bkelly, not reviewing]]

At a minimum I need the contents of:

  <profile>/storage/default/https+++new.cleopatra.io

Can you zip that up and email to me separately?

Comment 5

[Myk Melez [:myk] [@mykmelez]]

(In reply to Ben Kelly [:bkelly] from comment #4)
> At a minimum I need the contents of:
> 
>   <profile>/storage/default/https+++new.cleopatra.io
> 
> Can you zip that up and email to me separately?

Hmm, that doesn't exist.  I do have a variety of other directories in <profile>/storage/default/, but since I don't have that one, presumably the failure occurs before that directory is created.

Comment 6

[Myk Melez [:myk] [@mykmelez]]

Hmm, when I load https://new.cleopatra.io/, the Browser Console reports a couple errors associated with bug 1286914:

Quota 'url=https%3A%2F%2Fmichielbdejong.github.io%2Fmichielbdejong.com%2Fblog%2F16.html' is not a valid port number!: ActorsParent.cpp:6865
Quota Origin 'about+reader+url=https%3A%2F%2Fmichielbdejong.github.io%2Fmichielbdejong.com%2Fblog%2F16.html' failed to parse, handled tokens: 'about', 'reader': ActorsParent.cpp:6616
TypeError: ServiceWorker script at https://new.cleopatra.io/sw.js for scope https://new.cleopatra.io/ encountered an error during installation.

So I guess this is that bug.

Comment 7

[Myk Melez [:myk] [@mykmelez]]

Hmm, or perhaps it isn't a duplicate, since I still see it after deleting storage for the origin that breaks in bug 1286914.

I do see some other errors in the Error Console on startup that could be related:

IndexedDB UnknownErr: ActorsParent.cpp:591
IndexedDB UnknownErr: ActorsParent.cpp:591
undefined  Promise-backend.js:935
UnknownError  indexed-db.js:59:9

Comment 8

[Ben Kelly [:bkelly, not reviewing]]

We probably need a copy of the whole storage directory.  Jan should probably look since this looks like a QuotaManager issue.

If you don't have time to investigate with travel, please save off the profile so we can look into it next week.

Comment 9

[Myk Melez [:myk] [@mykmelez]]

(In reply to Ben Kelly [:bkelly] from comment #8)
> We probably need a copy of the whole storage directory.  Jan should probably
> look since this looks like a QuotaManager issue.
> 
> If you don't have time to investigate with travel, please save off the
> profile so we can look into it next week.

I've copied the directory, but it's very large (even after compression):

368M	storage
333M	storage.tbz2

It also contains much personal data.  Is there a useful subset I can provide to help diagnose the problem?

Comment 10

[Jan Varga [:janv]]

(In reply to Myk Melez [:myk] [@mykmelez] from comment #9)
> (In reply to Ben Kelly [:bkelly] from comment #8)
> > We probably need a copy of the whole storage directory.  Jan should probably
> > look since this looks like a QuotaManager issue.
> > 
> > If you don't have time to investigate with travel, please save off the
> > profile so we can look into it next week.
> 
> I've copied the directory, but it's very large (even after compression):
> 
> 368M	storage
> 333M	storage.tbz2
> 
> It also contains much personal data.  Is there a useful subset I can provide
> to help diagnose the problem?

A recursive directory listing of <profile>/storage should be enough for start.

Comment 11

[Jan Varga [:janv]]

Also, check the error console, there can be a warning, something like QuotaManager: OriginParser error ...

Comment 12

[Myk Melez [:myk] [@mykmelez]]

(In reply to Jan Varga [:janv] from comment #10)
> A recursive directory listing of <profile>/storage should be enough for
> start.

Ok, I've sent that to you directly via email.


(In reply to Jan Varga [:janv] from comment #11)
> Also, check the error console, there can be a warning, something like
> QuotaManager: OriginParser error ...

Hmm, I don't see any errors in the Browser Console when filtering on "quota".

Comment 13

[Dan Callahan [:callahad]]

I'm seeing the same on my daily use profile that's 10 months old. I use that profile exclusively with Nightly.

ni? jvarga: Did Myk's directory listing yield anything useful? How can I help track this down?

Comment 14

[Jan Varga [:janv]]

Tom, did fix this in a different bug ?

Comment 15

[Tom Tung [:tt, :ttung]]

The origin directory is:

about+reader+url=httpsxxxx

Which is not supported by the originParser yet. So that it crashes on a debug build at [1] (and fail on a non-debug build).

[1] https://searchfox.org/mozilla-central/rev/44a212460990ffffecf50a8e972d3cbde2e7216b/dom/quota/ActorsParent.cpp#8853

Given this is an initialization failure, I'm going to take this.

Comment 16

[Tom Tung [:tt, :ttung]]

About:reader's implementation is:
https://searchfox.org/mozilla-central/source/toolkit/components/reader/ReaderMode.jsm

It seems that the format should be:
about:reader?url=https.... or
about:reader?url=http....

Comment 17

[Tom Tung [:tt, :ttung]]

I'll work on this tomorrow if there is nothing unexpected happen. This should be done before the upgrade if it's needed.

Comment 18

[Tom Tung [:tt, :ttung]]

It seems URI would only be like "about:reader?url="

https://searchfox.org/mozilla-central/rev/227f5329f75bd8b16c6b146a7414598a420260cb/toolkit/components/reader/AboutReader.jsm#717-718

Comment 19

[Tom Tung [:tt, :ttung]]

So about:reader?url=xxx is striped to about:reader by bug 1422456. I need to see if it's reasonable to have storage for "about:reader?url=xxx"
If it's reasonable, then we should probably somehow get the stripped part back. If it's not, then we should remove existing about:reader from storage and forbidden new about:reader storage.

Comment 20

[Tom Tung [:tt, :ttung]]

While testing, I found that indexedDB, cache , and localstorage couldn't be got in "about:reader?url=xxx". The only possible way (IIUC) to have storage is to create that by the storage inspector.

Comment 21

[Andrew Sutherland [:asuth] (he/him)]

I think comment 20 may moot this, but I don't think we'd ever want the "?url=xxx" parameterization to partition the storage.

Comment 22

[Tom Tung [:tt, :ttung]]

Attachment: Bug 1322569 - Recognize the about:reader?url=xxx as an obsolete origin in quota manager;

Comment 23

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7acbbe02705e
Recognize the about:reader?url=xxx as an obsolete origin in quota manager; r=asuth

Comment 24

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/7acbbe02705e