[geckoview] Add header support to GeckoView.loadUri()

NEW
Assigned to

Status

defect
P3
normal
3 years ago
2 months ago

People

(Reporter: snorp, Assigned: snorp)

Tracking

Trunk
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Specifically, the flags are just wrong, since we don't support tabs. I think the flags should basically reflect whatever makes sense from nsLoadFlags (bypass cache, only use cache, etc).

Also, I think we want to be able to pass in some headers. Just a map of strings should be fine there, I think.
(In reply to James Willcox (:snorp) (jwillcox@mozilla.com) from comment #0)
> Specifically, the flags are just wrong, since we don't support tabs. I think
> the flags should basically reflect whatever makes sense from nsLoadFlags
> (bypass cache, only use cache, etc).
> 
> Also, I think we want to be able to pass in some headers. Just a map of
> strings should be fine there, I think.

To make this actually work in GeckoView, you need to define the nsIBrowserAccess interface, like at http://searchfox.org/mozilla-central/source/mobile/android/chrome/content/browser.js#360.  I have a hacky implementation this locally which I will try to push out.
Component: Embedding: APIs → GeckoView
Product: Core → Firefox for Android
Version: unspecified → Trunk
Assignee: nobody → snorp
Priority: -- → P1
Summary: [geckoview] Update GeckoView.loadUri() → [geckoview] Add flags/header support to GeckoView.loadUri()
We have flags now, but still no headers.
Summary: [geckoview] Add flags/header support to GeckoView.loadUri() → [geckoview] Add header support to GeckoView.loadUri()
P3 because this is not a Klar+GeckoView blocker
Priority: P1 → P3

Updated

6 months ago
Product: Firefox for Android → GeckoView
You need to log in before you can comment on or make changes to this bug.