1322577 - [geckoview] Add header support to GeckoView.loadUri()

Status: RESOLVED WORKSFORME

(GeckoView :: General, defect, P3)

Description

[James Willcox (:snorp) ([e-mail]) (he/him)]

Specifically, the flags are just wrong, since we don't support tabs. I think the flags should basically reflect whatever makes sense from nsLoadFlags (bypass cache, only use cache, etc).

Also, I think we want to be able to pass in some headers. Just a map of strings should be fine there, I think.

Comment 1

[Nick Alexander :nalexander [he/him]]

(In reply to James Willcox (:snorp) ([e-mail]) from comment #0)
> Specifically, the flags are just wrong, since we don't support tabs. I think
> the flags should basically reflect whatever makes sense from nsLoadFlags
> (bypass cache, only use cache, etc).
> 
> Also, I think we want to be able to pass in some headers. Just a map of
> strings should be fine there, I think.

To make this actually work in GeckoView, you need to define the nsIBrowserAccess interface, like at http://searchfox.org/mozilla-central/source/mobile/android/chrome/content/browser.js#360.  I have a hacky implementation this locally which I will try to push out.

Comment 3

[James Willcox (:snorp) ([e-mail]) (he/him)]

We have flags now, but still no headers.

Comment 4

[Chris Peterson [:cpeterson]]

P3 because this is not a Klar+GeckoView blocker

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee didn't login in Bugzilla in the last 7 months.
:amoya, could you have a look please?
For more information, please visit auto_nag documentation.

Comment 6

[Nick Alexander :nalexander [he/him]]

This has been supported for some time in GeckoView; see, for example, https://searchfox.org/mozilla-central/rev/82946eb5e7d1234f3218310e7bc8a394666dbda5/mobile/android/geckoview/src/main/java/org/mozilla/geckoview/GeckoSession.java#1549-1554.