Closed
Bug 1322599
Opened 8 years ago
Closed 5 years ago
[geckoview] Use abstract classes for delegates instead of interfaces
Categories
(GeckoView :: General, defect, P3)
GeckoView
General
Tracking
(Not tracked)
RESOLVED
INVALID
People
(Reporter: snorp, Unassigned)
References
Details
Or at the least, we should offer abstract classes that implement the current interfaces and have base functionality that makes sense. The benefit is that often you only want to implement some of the interface and not the whole thing, so this makes that convenient.
Comment 1•7 years ago
|
||
(In reply to James Willcox (:snorp) (jwillcox@mozilla.com) from comment #0) > Or at the least, we should offer abstract classes that implement the current > interfaces and have base functionality that makes sense. The benefit is that > often you only want to implement some of the interface and not the whole > thing, so this makes that convenient. One counter-argument: you often end up with `CanonicalNameDelegate` and `CanonicalNameDelegate2` when you want to version or improve things. I'm gently against this approach, because I think it contradicts the general strength of "prefer composition over inheritance".
Reporter | ||
Updated•7 years ago
|
Component: Embedding: APIs → GeckoView
Product: Core → Firefox for Android
Version: unspecified → Trunk
Reporter | ||
Updated•6 years ago
|
Priority: -- → P3
Updated•5 years ago
|
Product: Firefox for Android → GeckoView
Comment 2•5 years ago
•
|
||
We now have enforced default
impl in every delegate interface, so this is not needed anymore.
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → INVALID
You need to log in
before you can comment on or make changes to this bug.
Description
•