Make MediaError::message attribute available on all version

RESOLVED FIXED in Firefox 52

Status

()

Core
Audio/Video: Playback
RESOLVED FIXED
11 months ago
7 months ago

People

(Reporter: jya, Assigned: jya)

Tracking

({dev-doc-complete})

unspecified
mozilla53
dev-doc-complete
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox51 wontfix, firefox52 fixed, firefox53 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

11 months ago
HTML5 Specs have been amended to include the MediaError::message attribute.

We want to expose it on all versions, not just aurora and nightly...

https://github.com/whatwg/html/issues/2085
https://github.com/whatwg/html/pull/2086
(Assignee)

Updated

11 months ago
Assignee: nobody → jyavenard
(Assignee)

Updated

11 months ago
status-firefox51: --- → affected
status-firefox52: --- → affected
Comment hidden (mozreview-request)
(Assignee)

Updated

10 months ago
Keywords: dev-doc-needed
(Assignee)

Updated

10 months ago
Depends on: 1299072

Comment 2

10 months ago
mozreview-review
Comment on attachment 8817540 [details]
Bug 1322606: Don't hide MediaError::message behind a pref.

https://reviewboard.mozilla.org/r/97800/#review98674

r+ with two small comments:

* Can you please also remove http://searchfox.org/mozilla-central/rev/594937fec2e2fc45fa9308ba2fb964816631f017/dom/media/test/test_decode_error.html#58?
* Can you please send a quick intend to ship for this, mostly to inform folks.

Thank you!
Attachment #8817540 - Flags: review?(ehsan) → review+
(Assignee)

Updated

10 months ago
Attachment #8817540 - Flags: review?(bzbarsky)
(Assignee)

Comment 3

10 months ago
(In reply to :Ehsan Akhgari from comment #2)
> Comment on attachment 8817540 [details]
> Bug 1322606: Don't hide MediaError::message behind a pref.
> 
> https://reviewboard.mozilla.org/r/97800/#review98674
> 
> r+ with two small comments:
> 
> * Can you please also remove
> http://searchfox.org/mozilla-central/rev/
> 594937fec2e2fc45fa9308ba2fb964816631f017/dom/media/test/test_decode_error.
> html#58?
> * Can you please send a quick intend to ship for this, mostly to inform
> folks.

this was done yesterday... going to wait a few days for it to settle.
Comment hidden (mozreview-request)

Comment 5

10 months ago
Pushed by jyavenard@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3bbd52424e36
Don't hide MediaError::message behind a pref. r=Ehsan

Comment 6

10 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/3bbd52424e36
Status: NEW → RESOLVED
Last Resolved: 10 months ago
status-firefox53: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
Too late for 51. Mark 51 won't fix.
Hi :jya,
Is this worth uplifting to Aurora52?
status-firefox51: affected → wontfix
Flags: needinfo?(jyavenard)
(Assignee)

Comment 8

9 months ago
Comment on attachment 8817540 [details]
Bug 1322606: Don't hide MediaError::message behind a pref.

Approval Request Comment
[Feature/Bug causing the regression]: new feature
[User impact if declined]: not compliant with new W3C spec
[Is this code covered by automated tests?]: yes
[Has the fix been verified in Nightly?]: yes
[Needs manual test from QE? If yes, steps to reproduce]: no
[List of other uplifts needed for the feature/fix]: no
[Is the change risky?]: no
[Why is the change risky/not risky?]: adding a new attribute
[String changes made/needed]: none
Flags: needinfo?(jyavenard)
Attachment #8817540 - Flags: approval-mozilla-aurora?
Comment on attachment 8817540 [details]
Bug 1322606: Don't hide MediaError::message behind a pref.

expose MediaError::message, aurora52+
Attachment #8817540 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+

Comment 10

9 months ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-aurora/rev/ada364f7fa71
status-firefox52: affected → fixed
For documentation purposes: if I read this correctly, this is basically about making this property available by default on beta and release builds starting with Firefox 52. I assume it shipped enabled by default in Firefox 52 despite being labeled as “Fixed” in 53. Please advise if I’m wrong.
Yes, that's why "firefox52: fixed" in the tracking flags.
(In reply to Boris Zbarsky [:bz] (still a bit busy) from comment #12)
> Yes, that's why "firefox52: fixed" in the tracking flags.

Yeah, these accurate about 99.999% of the time, but I've been bitten a couple of times, so if I have any doubt at all, I double-check.
Documentation added:

https://developer.mozilla.org/en-US/docs/Web/API/MediaError/message
https://developer.mozilla.org/en-US/docs/Web/API/HTMLMediaElement/onerror

Documentation updated:

https://developer.mozilla.org/en-US/docs/Web/API/MediaError
https://developer.mozilla.org/en-US/docs/Web/API/HTMLMediaElement/error
https://developer.mozilla.org/en-US/docs/Web/Events/error

Listed on Firefox 52 for developers: https://developer.mozilla.org/en-US/Firefox/Releases/53#AudioVideoMedia

Example added to Github:

https://github.com/mdn/dom-examples/tree/master/media/mediaerror

This is now complete.
Keywords: dev-doc-needed → dev-doc-complete

Updated

7 months ago
Depends on: 1354633
You need to log in before you can comment on or make changes to this bug.