1322628 - EOS buffer released in wrong state

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Audio/Video, defect)

Description

[John Lin [:jhlin][:jolin]]

CodecProxy doesn't record EOS buffer [1]. When releasing it calls ICodec.stop() before ICodec.release() [2], which in turn flushes the unreleased output buffers [3].
But calling MediaCodec.releaseOutputBuffer() should be called before MediaCodec.stop() or it throws IllegalStateException.

[1] https://hg.mozilla.org/mozilla-central/rev/8282bb09dc78#l2.48
[2] http://searchfox.org/mozilla-central/source/mobile/android/base/java/org/mozilla/gecko/media/CodecProxy.java#123
[3] https://hg.mozilla.org/mozilla-central/diff/c871270d176e/mobile/android/base/java/org/mozilla/gecko/media/Codec.java#l1.286

Comment 1

[John Lin [:jhlin][:jolin]]

Attachment: Bug 1322628 - record EOS buffer in CodecProxy to make sure it'll be released before ICodec.stop() is called.

Review commit: https://reviewboard.mozilla.org/r/97808/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/97808/

Comment 2

[James Willcox (:snorp) ([e-mail]) (he/him)]

Comment on attachment 8817561 [details]
Bug 1322628 - record EOS buffer in CodecProxy to make sure it'll be released before ICodec.stop() is called.

https://reviewboard.mozilla.org/r/97808/#review98406

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/55878b84a3d6
record EOS buffer in CodecProxy to make sure it'll be released before ICodec.stop() is called. r=snorp

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/55878b84a3d6