1322661 - stylo: expose style sheets to devtools

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Cameron McCormack (:heycam)]

We are returning early from inDOMUtils::GetAllStyleSheets but now that we implement nsIDOMCSSStyleSheet on ServoStyleSheets, we can expose a document's sheets to devtools.  (Still not XBL sheets, though, which will need to wait until we support XBL at all in stylo.)

Comment 1

[Cameron McCormack (:heycam)]

Attachment: patch

Comment 2

[Cameron McCormack (:heycam)]

(Also this is hard to test since opening devtools still crashes the browser.)

Comment 3

[Xidorn Quan [:xidorn] UTC+10]

Comment on attachment 8817583 [details] [diff] [review]
patch

Review of attachment 8817583 [details] [diff] [review]:
-----------------------------------------------------------------

::: layout/inspector/inDOMUtils.cpp
@@ +96,5 @@
>      for (int32_t i = 0; i < styleSet->SheetCount(sheetType); i++) {
>        sheets.AppendElement(styleSet->StyleSheetAt(sheetType, i));
>      }
>      AutoTArray<CSSStyleSheet*, 32> xblSheetArray;
> +    if (styleSet->IsGecko()) {

It seems code from the variable definition line above to the end of the loop body is all useless for stylo at the moment. Probably wrap all of them inside the if-statement?

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/66ade78caf23
Expose (non-XBL) style sheets to devtools. r=xidorn

Comment 5

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/66ade78caf23