1322674 - Reader mode doesn't display a table column properly

Status: RESOLVED FIXED

(Toolkit :: Reader Mode, defect, P3)

Description

[u583025]

Attachment: Normal mode.png

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:50.0) Gecko/20100101 Firefox/50.0
Build ID: 20161130094630
Firefox for Android

Steps to reproduce:

Go to this page - https://android-developers.blogspot.in/2016/12/saving-data-reducing-the-size-of-app-updates-by-65-percent.html

Open Reader mode.


Actual results:

The first column entries in the table on that site is missing from the reader mode.


Expected results:

The first column entries should have been visible.

Comment 1

[u583025]

Attachment: Reader mode.png

Comment 2

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Evan, Gijs, any ideas?

Should text be not removed if it's in a table cell which will be kept?
Alternative: Keep tables if links are only in one row or column, else remove it entirely.

Comment 3

[:Gijs (he/him)]

I wrote a fix in https://github.com/mozilla/readability/pull/348

Comment 4

[Evan Tseng [:evanxd]]

review+ and already landed in GitHub repo[1].

[1]: https://github.com/mozilla/readability/commit/1369f923db3b0c4e00fdc4d70efd93fe2ee1fdf9

Comment 5

[Evan Tseng [:evanxd]]

Will land the patch in m-c in the mozreview request[1].

[1]: https://reviewboard.mozilla.org/r/114842/diff/1#index_header

Comment 6

[:Gijs (he/him)]

https://hg.mozilla.org/mozilla-central/rev/e04079f3f386