Closed
Bug 1322674
Opened 7 years ago
Closed 7 years ago
Reader mode doesn't display a table column properly
Categories
(Toolkit :: Reader Mode, defect, P3)
Toolkit
Reader Mode
Tracking
()
RESOLVED
FIXED
mozilla54
Tracking | Status | |
---|---|---|
firefox54 | --- | fixed |
People
(Reporter: u583025, Assigned: Gijs)
References
(Blocks 1 open bug)
Details
(Whiteboard: [reader-mode-readability-algorithm])
Attachments
(2 files)
User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:50.0) Gecko/20100101 Firefox/50.0 Build ID: 20161130094630 Firefox for Android Steps to reproduce: Go to this page - https://android-developers.blogspot.in/2016/12/saving-data-reducing-the-size-of-app-updates-by-65-percent.html Open Reader mode. Actual results: The first column entries in the table on that site is missing from the reader mode. Expected results: The first column entries should have been visible.
Updated•7 years ago
|
Status: UNCONFIRMED → NEW
Component: Untriaged → Reader Mode
Ever confirmed: true
Product: Firefox → Toolkit
Version: 50 Branch → Trunk
Assignee | ||
Updated•7 years ago
|
Priority: -- → P3
Whiteboard: [reader-mode-readability-algorithm]
Comment 2•7 years ago
|
||
Evan, Gijs, any ideas? Should text be not removed if it's in a table cell which will be kept? Alternative: Keep tables if links are only in one row or column, else remove it entirely.
Assignee | ||
Updated•7 years ago
|
Flags: needinfo?(gijskruitbosch+bugs)
Assignee | ||
Comment 3•7 years ago
|
||
I wrote a fix in https://github.com/mozilla/readability/pull/348
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Flags: needinfo?(gijskruitbosch+bugs)
Comment 4•7 years ago
|
||
review+ and already landed in GitHub repo[1]. [1]: https://github.com/mozilla/readability/commit/1369f923db3b0c4e00fdc4d70efd93fe2ee1fdf9
Comment 5•7 years ago
|
||
Will land the patch in m-c in the mozreview request[1]. [1]: https://reviewboard.mozilla.org/r/114842/diff/1#index_header
Assignee | ||
Comment 6•7 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/e04079f3f386
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox54:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
You need to log in
before you can comment on or make changes to this bug.
Description
•