If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Reader mode doesn't display a table column properly

RESOLVED FIXED in Firefox 54

Status

()

Toolkit
Reader Mode
P3
normal
RESOLVED FIXED
10 months ago
7 months ago

People

(Reporter: u583025, Assigned: Gijs)

Tracking

(Blocks: 1 bug)

Trunk
mozilla54
Points:
---

Firefox Tracking Flags

(firefox54 fixed)

Details

(Whiteboard: [reader-mode-readability-algorithm])

Attachments

(2 attachments)

(Reporter)

Description

10 months ago
Created attachment 8817598 [details]
Normal mode.png

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:50.0) Gecko/20100101 Firefox/50.0
Build ID: 20161130094630
Firefox for Android

Steps to reproduce:

Go to this page - https://android-developers.blogspot.in/2016/12/saving-data-reducing-the-size-of-app-updates-by-65-percent.html

Open Reader mode.


Actual results:

The first column entries in the table on that site is missing from the reader mode.


Expected results:

The first column entries should have been visible.
(Reporter)

Comment 1

10 months ago
Created attachment 8817599 [details]
Reader mode.png
(Reporter)

Updated

10 months ago
OS: Unspecified → All
Hardware: Unspecified → All
Status: UNCONFIRMED → NEW
Component: Untriaged → Reader Mode
Ever confirmed: true
Product: Firefox → Toolkit
Version: 50 Branch → Trunk
(Assignee)

Updated

10 months ago
Priority: -- → P3
Whiteboard: [reader-mode-readability-algorithm]
Evan, Gijs, any ideas?

Should text be not removed if it's in a table cell which will be kept?
Alternative: Keep tables if links are only in one row or column, else remove it entirely.
(Assignee)

Updated

9 months ago
Flags: needinfo?(gijskruitbosch+bugs)
(Assignee)

Comment 3

8 months ago
I wrote a fix in https://github.com/mozilla/readability/pull/348
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Flags: needinfo?(gijskruitbosch+bugs)

Comment 4

8 months ago
review+ and already landed in GitHub repo[1].

[1]: https://github.com/mozilla/readability/commit/1369f923db3b0c4e00fdc4d70efd93fe2ee1fdf9

Comment 5

7 months ago
Will land the patch in m-c in the mozreview request[1].

[1]: https://reviewboard.mozilla.org/r/114842/diff/1#index_header
(Assignee)

Comment 6

7 months ago
https://hg.mozilla.org/mozilla-central/rev/e04079f3f386
Status: ASSIGNED → RESOLVED
Last Resolved: 7 months ago
status-firefox54: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla54

Updated

7 months ago
Blocks: 1329358
You need to log in before you can comment on or make changes to this bug.