Closed Bug 1322674 Opened 3 years ago Closed 3 years ago

Reader mode doesn't display a table column properly

Categories

(Toolkit :: Reader Mode, defect, P3)

defect

Tracking

()

RESOLVED FIXED
mozilla54
Tracking Status
firefox54 --- fixed

People

(Reporter: u583025, Assigned: Gijs)

References

(Blocks 1 open bug)

Details

(Whiteboard: [reader-mode-readability-algorithm])

Attachments

(2 files)

Attached image Normal mode.png
User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:50.0) Gecko/20100101 Firefox/50.0
Build ID: 20161130094630
Firefox for Android

Steps to reproduce:

Go to this page - https://android-developers.blogspot.in/2016/12/saving-data-reducing-the-size-of-app-updates-by-65-percent.html

Open Reader mode.


Actual results:

The first column entries in the table on that site is missing from the reader mode.


Expected results:

The first column entries should have been visible.
Attached image Reader mode.png
OS: Unspecified → All
Hardware: Unspecified → All
Status: UNCONFIRMED → NEW
Component: Untriaged → Reader Mode
Ever confirmed: true
Product: Firefox → Toolkit
Version: 50 Branch → Trunk
Priority: -- → P3
Whiteboard: [reader-mode-readability-algorithm]
Evan, Gijs, any ideas?

Should text be not removed if it's in a table cell which will be kept?
Alternative: Keep tables if links are only in one row or column, else remove it entirely.
Flags: needinfo?(gijskruitbosch+bugs)
I wrote a fix in https://github.com/mozilla/readability/pull/348
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Flags: needinfo?(gijskruitbosch+bugs)
Will land the patch in m-c in the mozreview request[1].

[1]: https://reviewboard.mozilla.org/r/114842/diff/1#index_header
https://hg.mozilla.org/mozilla-central/rev/e04079f3f386
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
Blocks: 1329358
You need to log in before you can comment on or make changes to this bug.