1322678 - Title of image tab changes back to filename on user zoom

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect, P3)

Description

[vincent.spallek]

Attachment: zoom-bug.html

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Firefox/45.0; Firefox 45.5.1 - 11712-1502020039-1.31
Build ID: 20161129180326

Steps to reproduce:

Create a webpage that opens a huge image in a new tab with JavaScript and changes the title of that new tab after load.
Initially, the new tab is shown with the custom title, and the image is zoomed to show the full image.
If clicking on the image with the mouse, the image zooms to 100%. 


Actual results:

In this moment, the tab's title is changed back to the filename of the image.
If using CTRL + "+" or CTRL + "-" for zooming, then the title is not changed (as expected).


Expected results:

The tab's title shouldn't change.

Comment 1

[YF (Yang)]

I see this problem in 45.5.1esr and Fx51b6, with the testcase and a local image file. But the custom title will be overwritten immediately if use image on web address. And the tab title will be overwritten every time the page zoom (not image zoom) level reaches 100%, including using the hotkey.

Comment 2

[YF (Yang)]

For local image file, add "newWin.addEventListener('resize', function() {" will fix the problem. But it seems useless to open web image.

Comment 3

[vincent.spallek]

Use case is if the underlying CMS is generating a really ugly long URL for an uploaded image, but we want to show the familiar filename to the user.

Comment 4

[vincent.spallek]

… otherwise, the tab title is completely useless to the user if several tabs are open.

Comment 5

[YF (Yang)]

In this case, using a page, iframe or AJAX element to display, or generate a short and pseudo-URL, may be a better way.

Or, may the Content-Disposition:"inline; filename="jshang.png"" right for you? like https://bug1320571.bmoattachments.org/attachment.cgi?id=8816766.

Comment 6

[ovidiu boca[:Ovidiu]]

Hi,
The attachment from description is not working. YF based on the fact that you succeeded to reproduce this can you think to a component for this bug?

Comment 7

[YF (Yang)]

I've reproduced the reporter's problem, but I don't know if it's a problem with this example or a browser issue.

Comment 8

[ovidiu boca[:Ovidiu]]

This issue reproduces on other browsers?

Comment 9

[vincent.spallek]

I tried my example on IE and Chrome on Windows as well. Both browsers do not show this bug but show the expected behavior: the tab's title doesn't change back.

Comment 10

[ovidiu boca[:Ovidiu]]

I opened the attached file and clicked on "Link" the result is "Object not found". How can I use the attached file? Thanks

Comment 11

[vincent.spallek]

The attached file is meant as documentation, please read its source code. To make it work, you need to change it to open an image with dimensions bigger than your screen.

Comment 12

[:Gijs (he/him)]

This is because of the implementation of https://dxr.mozilla.org/mozilla-central/source/dom/html/ImageDocument.cpp , which updates the title to include zoom factors etc. I guess it should be taught not to overwrite custom-set titles.

Comment 13

[Andrew Overholt [:overholt]]

Edgar, can you take a look?

Comment 14

[Edgar Chen [:edgar]]

I can reproduce this on Mac and Linux as well.

Comment 15

[Edgar Chen [:edgar]]

Attachment: Bug 1322678 - Don't overwrite the custom-set title of ImageDocument;

Comment 16

[Edgar Chen [:edgar]]

https://treeherder.mozilla.org/#/jobs?repo=try&tier=1&revision=fc58e49a1e673c873407f786e78b4274468acfb7&group_state=expanded

Comment 17

[Edgar Chen [:edgar]]

https://treeherder.mozilla.org/#/jobs?repo=try&tier=1&revision=fd8de2c8ce01f83e857af4a5d8afb2b07c3bf052&group_state=expanded

Comment 18

[Edgar Chen [:edgar]]

(In reply to Edgar Chen [:edgar] from comment #17)
> https://treeherder.mozilla.org/#/
> jobs?repo=try&tier=1&revision=fd8de2c8ce01f83e857af4a5d8afb2b07c3bf052&group_
> state=expanded

There are some failures that are actually not related to this change. Rebase and try again, https://treeherder.mozilla.org/#/jobs?repo=try&tier=1&group_state=expanded&revision=8154027e4ffce44797aaef7fa5ac7a57aeb5857a, it looks good now.

Comment 19

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6343e6061b9e
Don't overwrite the custom-set title of ImageDocument; r=smaug

Comment 20

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/6343e6061b9e