1322708 - Improve the console warnings for when a video source failed, but a valid source was then found

Status: RESOLVED FIXED

(Core :: Audio/Video, enhancement)

Description

[Karl Dubost💡 :karlcow]

This is a piece of code of The Guardian home page today.
https://www.theguardian.com/us

<video controls="" class="gu-media gu-media--video" data-title="What is it like to have no home?" data-auto-play="false" data-show-end-slate="false" data-duration="191" data-media-id="gu-video-584ab839e4b04a74f2781c90" data-end-slate="/global/video/2016/dec/09/kids-refugees-questions-whats-it-like-to-have-no-home-video" data-block-video-ads="false" data-embeddable="false" preload="none" data-canonical-url="global/video/2016/dec/09/kids-refugees-questions-whats-it-like-to-have-no-home-video">
    <source src="https://cdn.theguardian.tv/HLS/2016/12/09/161209CharityAppealVideov3.m3u8" type="video/m3u8">
    <source src="https://cdn.theguardian.tv/mainwebsite/2016/12/09/161209CharityAppealVideov3_desk.mp4" type="video/mp4">
    <source src="https://cdn.theguardian.tv/webM/2016/12/09/161209CharityAppealVideov3_V5.webm" type="video/webm">
</video>

The console displays:

     Specified “type” attribute of “video/m3u8” is not supported. 
     Load of media resource https://cdn.theguardian.tv/HLS/2016/12/09/161209CharityAppealVideov3.m3u8 failed.

without the link to the line in the HTML inspector.


Suggestion:

The warning message might be missing information or have too much information.

For such warnings, I would either 
* remove it because the developer has a valid source for Firefox 
* or add a context saying that indeed there is a m3u8 but also a valid source for the videos.

Comment 1

[Brian Grinstead [:bgrins]]

Based on blame of the MediaLoadHttpError string usage, this message was added in Bug 712134.  Chris, do you have an opinion on if we should make a change here for the case where one source failed to load but it ultimately found one?

Also, I was wondering: is there a way that we can detect which source has been loaded from JS so that we can highlight it in the Inspector tool as another way to help devs figure out which is being used?

Comment 2

[Chris Pearce [:cpearce (Not reading bugmail)]]

(In reply to Brian Grinstead [:bgrins] from comment #1)
> Based on blame of the MediaLoadHttpError string usage, this message was
> added in Bug 712134.  Chris, do you have an opinion on if we should make a
> change here for the case where one source failed to load but it ultimately
> found one?

We're hitting MediaLoadUnsupportedTypeAttribute here I think, not MediaLoadHttpError.

We could change HTMLMediaElement::LoadFromSourceChildren() to log a different string if there is another source child to try loading from, i.e. in the case where we fail to load from the first child, but we know there is at least one more child, we could instead log:

"Specified “type” attribute of “%1$S” is not supported. Load of media resource %2$S failed. Trying to load from next <source> element".



> Also, I was wondering: is there a way that we can detect which source has
> been loaded from JS so that we can highlight it in the Inspector tool as
> another way to help devs figure out which is being used?

The URL of the resource that was loaded is stored in HTMLMediaElement.currentSrc.

Comment 3

[Patrick Brosset <:pbro>]

Brian filed bug 1323051 for the inspector part (showing which source was used in the media element). I think we should keep this bug to improve the console message as proposed by Chris in comment 2:

"Specified “type” attribute of “%1$S” is not supported. Load of media resource %2$S failed. Trying to load from next <source> element".

This is what would address Karl's request the best I think. So moving this to being an enhancement, and moving it to the appropriate component.

Comment 4

[Micah [:mtigley] (she/her)]

I'll give this one a shot.

Comment 5

[Micah [:mtigley] (she/her)]

Attachment: Bug 1322708 - Improve console warnings for unsupported media resource.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1baf8637bb47
Improve console warnings for unsupported media resource. r=smaug

Comment 7

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/1baf8637bb47