1322796 - Don't assume snapshot requests will always be the full buffer size

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect, P3)

Description

[Kartikaya Gupta (email:[e-mail])]

https://hg.mozilla.org/projects/graphics/file/73bdd29461ae/gfx/layers/wr/WebRenderBridgeParent.cpp#l370 is a false assumption. The rect passed in might be a smaller area of the full texture. In that case the expectation is that we will get a snapshot of the requested subrect and update the relevant pixels in the texture with that subrect.

However doing that is a little complicated so for now I'd like to just always do a full snapshot so that we can get the reftests running without crashes. (Failing to do this triggers a panic inside gleam somewhere - https://hg.mozilla.org/try/file/692105fb7299b46274b59827d9b87baeb5bf4f96/third_party/rust/gleam/src/gl.rs#l96)

Comment 1

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/projects/graphics/rev/1399cee329f2
Don't assume the snapshot area is the same as the buffer. r=mchang?

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/projects/graphics/rev/69ad226cd228
Correctly flip surface pattern for reftests. r=kats?