1322946 - Add more tests for <dialog> "close" event

Status: RESOLVED WONTFIX

(Core :: DOM: Core & HTML, defect, P3)

Comment 1

[Tim Nguyen :ntim]

Unassigning to reflect real status.

Comment 2

[Sean Feng [:sefeng211]]

Tim, I am not sure what we need to add for this bug, and I think the wpt test have it well covered https://github.com/web-platform-tests/wpt/blob/master/html/semantics/interactive-elements/the-dialog-element/dialog-close.html.

So I am closing this, but feel free to reopen it :)

Comment 3

[Sean Feng [:sefeng211]]

oh I misread the title, I was thinking the close method.

I sorted of added some "close" event test in bug 1322947, but I think I can/should add one just for this event particularly.

Reopening!

Comment 4

[Sean Feng [:sefeng211]]

Actually, the "close" event gets its own coverage at here, and as I mentioned in the above comment, the tests of the "close" event that should be fired when the dialog is canclled gets covered in bug 1322947.

So I changed my mind again and I think we are good. Sorry for the spamming.