The default bug view has changed. See this FAQ.

devedition.inc.css can stop resetting padding-top and padding-bottom on #nav-bar-customization-target

RESOLVED FIXED in Firefox 53

Status

()

Firefox
Theme
P3
normal
RESOLVED FIXED
4 months ago
3 months ago

People

(Reporter: dao, Assigned: Aniruddha Patil, Mentored)

Tracking

({good-first-bug})

Trunk
Firefox 53
Unspecified
Mac OS X
good-first-bug
Points:
---

Firefox Tracking Flags

(firefox53 fixed)

Details

(Whiteboard: [good first bug][lang=css])

Attachments

(1 attachment)

(Reporter)

Description

4 months ago
Bug 1322430 made the Mac theme not set padding-top and padding-bottom on #nav-bar-customization-target anymore. The Windows and Linux themes didn't set padding-top or padding-bottom in the first place. This means that #nav-bar-customization-target is now redundant here:

https://dxr.mozilla.org/mozilla-central/rev/8103c612b79c2587ea4ca1b0a9f9f82db4b185b8/browser/themes/shared/devedition.inc.css#234
(Reporter)

Updated

4 months ago
Priority: -- → P3
(Reporter)

Updated

3 months ago
Mentor: dao+bmo@mozilla.com
(Assignee)

Comment 1

3 months ago
Hello! I would like to take up this bug. Since this is my first bug, a little information on how to get started would help me greatly.
(Reporter)

Comment 2

3 months ago
(In reply to Aniruddha Patil from comment #1)
> Hello! I would like to take up this bug. Since this is my first bug, a
> little information on how to get started would help me greatly.

Have you already built Firefox?
https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Build_Instructions/Simple_Firefox_build
(Assignee)

Comment 3

3 months ago
(In reply to Dão Gottwald [:dao] from comment #2)
> (In reply to Aniruddha Patil from comment #1)
> > Hello! I would like to take up this bug. Since this is my first bug, a
> > little information on how to get started would help me greatly.
> 
> Have you already built Firefox?
> https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/
> Build_Instructions/Simple_Firefox_build

Yes. I've built it.
(Reporter)

Comment 4

3 months ago
The next step would be to open browser/themes/shared/devedition.inc.css in the editor of your choice and make the change that I described in comment 0.
(Assignee)

Comment 5

3 months ago
(In reply to Dão Gottwald [:dao] from comment #4)
> The next step would be to open browser/themes/shared/devedition.inc.css in
> the editor of your choice and make the change that I described in comment 0.

I have removed the redundancy as you had described.
(Reporter)

Comment 6

3 months ago
Have you created a patch?
(Assignee)

Comment 7

3 months ago
No. How do I make one?
(Reporter)

Comment 8

3 months ago
The simplest way is hg diff:

https://developer.mozilla.org/en-US/docs/Mercurial/Using_Mercurial#How_can_I_diff_and_patch_files.3F
(Assignee)

Comment 9

3 months ago
(In reply to Dão Gottwald [:dao] from comment #8)
> The simplest way is hg diff:
> 
> https://developer.mozilla.org/en-US/docs/Mercurial/
> Using_Mercurial#How_can_I_diff_and_patch_files.3F

I have made a local commit. Using hg push review tells me to provide an ircnick. But I do not have one. How do I proceed further?
(Reporter)

Comment 10

3 months ago
Not sure how that works. After committing you can also just export the patch using hg export, then upload the patch file manually as an attachment on this bug page.
(Assignee)

Comment 11

3 months ago
Created attachment 8819756 [details] [diff] [review]
bug1322975.patch
(Assignee)

Comment 12

3 months ago
(In reply to Dão Gottwald [:dao] from comment #10)
> Not sure how that works. After committing you can also just export the patch
> using hg export, then upload the patch file manually as an attachment on
> this bug page.

I have attached the patch as you said.
(Reporter)

Comment 13

3 months ago
Comment on attachment 8819756 [details] [diff] [review]
bug1322975.patch

Perfect, thanks!
Attachment #8819756 - Flags: review+
(Reporter)

Updated

3 months ago
Assignee: nobody → aniruddhavivekpatil

Comment 14

3 months ago
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5926190be105
Removed the redundant #nav-bar-customization-target in devedition.inc.css. r=dao
(Assignee)

Comment 15

3 months ago
(In reply to Dão Gottwald [:dao] from comment #13)
> Comment on attachment 8819756 [details] [diff] [review]
> bug1322975.patch
> 
> Perfect, thanks!

Thanks for the guidance! :)

Comment 16

3 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/5926190be105
Status: NEW → RESOLVED
Last Resolved: 3 months ago
status-firefox53: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 53
You need to log in before you can comment on or make changes to this bug.