1322975 - devedition.inc.css can stop resetting padding-top and padding-bottom on #nav-bar-customization-target

Status: RESOLVED FIXED

(Firefox :: Theme, defect, P3)

Description

[Dão Gottwald [:dao]]

Bug 1322430 made the Mac theme not set padding-top and padding-bottom on #nav-bar-customization-target anymore. The Windows and Linux themes didn't set padding-top or padding-bottom in the first place. This means that #nav-bar-customization-target is now redundant here:

https://dxr.mozilla.org/mozilla-central/rev/8103c612b79c2587ea4ca1b0a9f9f82db4b185b8/browser/themes/shared/devedition.inc.css#234

Comment 1

[Aniruddha Patil]

Hello! I would like to take up this bug. Since this is my first bug, a little information on how to get started would help me greatly.

Comment 2

[Dão Gottwald [:dao]]

(In reply to Aniruddha Patil from comment #1)
> Hello! I would like to take up this bug. Since this is my first bug, a
> little information on how to get started would help me greatly.

Have you already built Firefox?
https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Build_Instructions/Simple_Firefox_build

Comment 3

[Aniruddha Patil]

(In reply to Dão Gottwald [:dao] from comment #2)
> (In reply to Aniruddha Patil from comment #1)
> > Hello! I would like to take up this bug. Since this is my first bug, a
> > little information on how to get started would help me greatly.
> 
> Have you already built Firefox?
> https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/
> Build_Instructions/Simple_Firefox_build

Yes. I've built it.

Comment 4

[Dão Gottwald [:dao]]

The next step would be to open browser/themes/shared/devedition.inc.css in the editor of your choice and make the change that I described in comment 0.

Comment 5

[Aniruddha Patil]

(In reply to Dão Gottwald [:dao] from comment #4)
> The next step would be to open browser/themes/shared/devedition.inc.css in
> the editor of your choice and make the change that I described in comment 0.

I have removed the redundancy as you had described.

Comment 6

[Dão Gottwald [:dao]]

Have you created a patch?

Comment 7

[Aniruddha Patil]

No. How do I make one?

Comment 8

[Dão Gottwald [:dao]]

The simplest way is hg diff:

https://developer.mozilla.org/en-US/docs/Mercurial/Using_Mercurial#How_can_I_diff_and_patch_files.3F

Comment 9

[Aniruddha Patil]

(In reply to Dão Gottwald [:dao] from comment #8)
> The simplest way is hg diff:
> 
> https://developer.mozilla.org/en-US/docs/Mercurial/
> Using_Mercurial#How_can_I_diff_and_patch_files.3F

I have made a local commit. Using hg push review tells me to provide an ircnick. But I do not have one. How do I proceed further?

Comment 10

[Dão Gottwald [:dao]]

Not sure how that works. After committing you can also just export the patch using hg export, then upload the patch file manually as an attachment on this bug page.

Comment 11

[Aniruddha Patil]

Attachment: bug1322975.patch

Comment 12

[Aniruddha Patil]

(In reply to Dão Gottwald [:dao] from comment #10)
> Not sure how that works. After committing you can also just export the patch
> using hg export, then upload the patch file manually as an attachment on
> this bug page.

I have attached the patch as you said.

Comment 13

[Dão Gottwald [:dao]]

Comment on attachment 8819756 [details] [diff] [review]
bug1322975.patch

Perfect, thanks!

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5926190be105
Removed the redundant #nav-bar-customization-target in devedition.inc.css. r=dao

Comment 15

[Aniruddha Patil]

(In reply to Dão Gottwald [:dao] from comment #13)
> Comment on attachment 8819756 [details] [diff] [review]
> bug1322975.patch
> 
> Perfect, thanks!

Thanks for the guidance! :)

Comment 16

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/5926190be105