Closed Bug 1322975 Opened 3 years ago Closed 3 years ago

devedition.inc.css can stop resetting padding-top and padding-bottom on #nav-bar-customization-target

Categories

(Firefox :: Theme, defect, P3)

Unspecified
macOS
defect

Tracking

()

RESOLVED FIXED
Firefox 53
Tracking Status
firefox53 --- fixed

People

(Reporter: dao, Assigned: aniruddhavivekpatil, Mentored)

References

Details

(Keywords: good-first-bug, Whiteboard: [good first bug][lang=css])

Attachments

(1 file)

Bug 1322430 made the Mac theme not set padding-top and padding-bottom on #nav-bar-customization-target anymore. The Windows and Linux themes didn't set padding-top or padding-bottom in the first place. This means that #nav-bar-customization-target is now redundant here:

https://dxr.mozilla.org/mozilla-central/rev/8103c612b79c2587ea4ca1b0a9f9f82db4b185b8/browser/themes/shared/devedition.inc.css#234
Priority: -- → P3
Mentor: dao+bmo
Hello! I would like to take up this bug. Since this is my first bug, a little information on how to get started would help me greatly.
(In reply to Aniruddha Patil from comment #1)
> Hello! I would like to take up this bug. Since this is my first bug, a
> little information on how to get started would help me greatly.

Have you already built Firefox?
https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Build_Instructions/Simple_Firefox_build
(In reply to Dão Gottwald [:dao] from comment #2)
> (In reply to Aniruddha Patil from comment #1)
> > Hello! I would like to take up this bug. Since this is my first bug, a
> > little information on how to get started would help me greatly.
> 
> Have you already built Firefox?
> https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/
> Build_Instructions/Simple_Firefox_build

Yes. I've built it.
The next step would be to open browser/themes/shared/devedition.inc.css in the editor of your choice and make the change that I described in comment 0.
(In reply to Dão Gottwald [:dao] from comment #4)
> The next step would be to open browser/themes/shared/devedition.inc.css in
> the editor of your choice and make the change that I described in comment 0.

I have removed the redundancy as you had described.
Have you created a patch?
No. How do I make one?
(In reply to Dão Gottwald [:dao] from comment #8)
> The simplest way is hg diff:
> 
> https://developer.mozilla.org/en-US/docs/Mercurial/
> Using_Mercurial#How_can_I_diff_and_patch_files.3F

I have made a local commit. Using hg push review tells me to provide an ircnick. But I do not have one. How do I proceed further?
Not sure how that works. After committing you can also just export the patch using hg export, then upload the patch file manually as an attachment on this bug page.
Attached patch bug1322975.patchSplinter Review
(In reply to Dão Gottwald [:dao] from comment #10)
> Not sure how that works. After committing you can also just export the patch
> using hg export, then upload the patch file manually as an attachment on
> this bug page.

I have attached the patch as you said.
Comment on attachment 8819756 [details] [diff] [review]
bug1322975.patch

Perfect, thanks!
Attachment #8819756 - Flags: review+
Assignee: nobody → aniruddhavivekpatil
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5926190be105
Removed the redundant #nav-bar-customization-target in devedition.inc.css. r=dao
(In reply to Dão Gottwald [:dao] from comment #13)
> Comment on attachment 8819756 [details] [diff] [review]
> bug1322975.patch
> 
> Perfect, thanks!

Thanks for the guidance! :)
https://hg.mozilla.org/mozilla-central/rev/5926190be105
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 53
You need to log in before you can comment on or make changes to this bug.