1322983 - Unconditionally build the minidump-analyzer tool

Status: RESOLVED FIXED

(Toolkit :: Crash Reporting, defect)

Description

[Gabriele Svelto [:gsvelto]]

+++ This bug was initially created as a clone of Bug #1317968 +++

The minidump-analyzer tool is currently build only on nightly but it's unconditionally included in the distribution. Rather than putting conditionals everywhere for its inclusion let's build it unconditionally but only enable it's functionality on nightly and aurora.

Comment 1

[Gabriele Svelto [:gsvelto]]

Attachment: [PATCH] Unconditionally build the minidump-analyzer but run it only on nightly/aurora

This should fix the issue, the try run is here:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=585b394a3a4ac2ab2bd77b2cf3f6a976376576a5

Comment 2

[Gabriele Svelto [:gsvelto]]

Comment on attachment 8817994 [details] [diff] [review]
[PATCH] Unconditionally build the minidump-analyzer but run it only on nightly/aurora

This builds the minidump-analyzer unconditionally but then only runs it on nightly/aurora. Hopefully we'll turn it on soon enough on the other channels too.

Comment 3

[Gabriele Svelto [:gsvelto]]

Thanks for the quick review Ted! Try looks green, pushing...

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f49e998f4b6a
Unconditionally build the minidump-analyzer but run it only on nightly/aurora r=ted

Comment 5

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/f49e998f4b6a

Comment 6

[Gabriele Svelto [:gsvelto]]

Comment on attachment 8817994 [details] [diff] [review]
[PATCH] Unconditionally build the minidump-analyzer but run it only on nightly/aurora

Approval Request Comment
[Feature/Bug causing the regression]: Required to uplift bug 1317968
[User impact if declined]: We won't be able to automatically gather detailed data on user crashes
[Is this code covered by automated tests?]: No
[Has the fix been verified in Nightly?]: Yes
[Needs manual test from QE? If yes, steps to reproduce]: No
[List of other uplifts needed for the feature/fix]: Bug 1317968 which has already been approved for uplift
[Is the change risky?]: No
[Why is the change risky/not risky?]: This is a very simple change enabled only on nightly and aurora
[String changes made/needed]: None

Comment 7

[Julien Cristau [:jcristau]]

Comment on attachment 8817994 [details] [diff] [review]
[PATCH] Unconditionally build the minidump-analyzer but run it only on nightly/aurora

always build minidump-analyzer, aurora52+

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/84c4cc76070f

Comment 9

[Gabriele Svelto [:gsvelto]]

(In reply to Ryan VanderMeulen [:RyanVM] from comment #8)
> https://hg.mozilla.org/releases/mozilla-aurora/rev/84c4cc76070f

Thanks for landing this Ryan; I've wasted most of Friday morning fighting with hg graft without much success :-|