1323109 - [DateTimePicker] Date time picker popup does not open near input box

Status: VERIFIED FIXED

(Toolkit :: UI Widgets, defect)

Description

[Scott Wu [:scottwu]]

Date time pickers should open near the input box. And according to the visual spec, the popup should open directly below the input box, with its left side align with the input box.

Comment 1

[Scott Wu [:scottwu]]

Attachment: Bug 1323109 - Fixed date time pickers popup position;

Review commit: https://reviewboard.mozilla.org/r/98306/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/98306/

Comment 2

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

I didn't actually see the UI on Nightly yet, but this bug sounds to be a "visual alignment" to be work on within current milestone (Date picker MVP).

Comment 3

[Scott Wu [:scottwu]]

The x & y coordinates were set incorrectly, so that the popup opens at the wrong place most of the time, except when the input box is on the top left. A css stylesheet is also created for the popup, which overrides the rules that shifts the arrowpanel slightly.

Mike, does this look okay to you? Thanks in advance :)

Comment 4

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8818182 [details]
Bug 1323109 - Fixed date time pickers popup position;

https://reviewboard.mozilla.org/r/98306/#review98858

Thanks!

::: toolkit/modules/DateTimePickerHelper.jsm:144
(Diff revision 1)
>        return;
>      }
>      this.picker.loadPicker(type, detail);
>      // The arrow panel needs an anchor to work. The popupAnchor (this._anchor)
>      // is a transparent div that the arrow can point to.
> -    this.picker.openPopup(this._anchor, "after_start", rect.left, rect.top);
> +    this.picker.openPopup(this._anchor, "after_start", 0, 0);

Whoops. :/ Good catch!

Comment 5

[Scott Wu [:scottwu]]

Comment on attachment 8818182 [details]
Bug 1323109 - Fixed date time pickers popup position;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/98306/diff/1-2/

Comment 6

[Scott Wu [:scottwu]]

Thanks Mike! Rebased to central.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d2f2bc0b67e2
Fixed date time pickers popup position; r=mconley

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/d2f2bc0b67e2

Comment 9

[roxleitan]

Verified as fixed using the latest Nightly 54.0a1(Build ID: 20170201030207) and latest Aurora 53.0a2(Build ID: 20170201004003)on Ubuntu 16.04 and Mac OS X 10.10.

The issue is still reproducible on Windows. I filed bug 1332242.