[jsplugins] Add license for Chromium and third party code in mortar project

RESOLVED FIXED in Firefox 53

Status

()

Core
Plug-ins
RESOLVED FIXED
8 months ago
5 months ago

People

(Reporter: louis, Assigned: louis)

Tracking

unspecified
mozilla53
Points:
---

Firefox Tracking Flags

(firefox53 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

8 months ago
In this bug, we would:
1) Add license for Chromium code inside browser/extensions/mortar/ppapi/
2) Add license for third party code inside browser/extensions/mortar/json/
3) Add license for third party code inside browser/extensions/mortar/host/common/opengles2-utils.jsm
(Assignee)

Updated

8 months ago
Assignee: nobody → lochang
No longer blocks: 1309444
Summary: [jsplugins] Add license for Chromium and third party code for mortar project → [jsplugins] Add license for Chromium and third party code in mortar project
(Assignee)

Comment 1

8 months ago
Created attachment 8818183 [details] [diff] [review]
Bug 1323120 - Add license for Chromium and thrid party code in mortar project

Based on our offline discussion with Elvin, i submit the patch which add license for chromium and third party code in mortar project.

Hi Vance, would you please take a look at the patch see if there is still something missing and also ask for the right person to review? Thanks!
Flags: needinfo?(vchen)
(Assignee)

Comment 2

8 months ago
Created attachment 8818211 [details] [diff] [review]
[Final] Bug 1323120 - Add license for Chromium and thrid party code in mortar project, r=gerv

Rename the JSON license to JSMN license.
Attachment #8818183 - Attachment is obsolete: true
Hi Gerv, could you help to review this patch ? 

And to provide some context:

We are going to land Project Mortar[1] into m-c. We have submitted Bug#1313295 for code review and Bug#1314029 for legal discussions. In Hawaii we have met with Elvin and he pointed out that in order to land Mortar project on m-c we should modify the license.html file to cover:

1. The PPAPI source code we got from Google Chromium project and use in the Mortar project.
2. The json source files.
3. The opengles2-utils.jsm files.

So please help to check if the modification is OK

[1]https://wiki.mozilla.org/Mortar_Project
Flags: needinfo?(vchen) → needinfo?(gerv)
(Assignee)

Comment 4

8 months ago
Comment on attachment 8818211 [details] [diff] [review]
[Final] Bug 1323120 - Add license for Chromium and thrid party code in mortar project, r=gerv

Directly set review flag to Gerv.
Attachment #8818211 - Flags: review?(gerv)
Comment on attachment 8818211 [details] [diff] [review]
[Final] Bug 1323120 - Add license for Chromium and thrid party code in mortar project, r=gerv

Review of attachment 8818211 [details] [diff] [review]:
-----------------------------------------------------------------

r=gerv.

Gerv
Attachment #8818211 - Flags: review?(gerv) → review+

Updated

8 months ago
Flags: needinfo?(gerv)
(Assignee)

Updated

8 months ago
Attachment #8818211 - Attachment description: Bug 1323120 - Add license for Chromium and thrid party code in mortar project → [Final] Bug 1323120 - Add license for Chromium and thrid party code in mortar project, r=gerv
(Assignee)

Updated

8 months ago
Keywords: checkin-needed
(Assignee)

Comment 6

8 months ago
Thanks for Gerv's review.

Comment 7

8 months ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/6768b6d8ba5a
Add license for Chromium and third party code in mortar project. r=gerv
Keywords: checkin-needed

Comment 8

8 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/6768b6d8ba5a
Status: NEW → RESOLVED
Last Resolved: 8 months ago
status-firefox53: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
(Assignee)

Updated

5 months ago
Depends on: 1347440
(Assignee)

Updated

5 months ago
No longer depends on: 1347440
You need to log in before you can comment on or make changes to this bug.