Closed Bug 1323134 Opened 4 years ago Closed 4 years ago

SessionStore.jsm shouldn't set the crop attribute on tabs anymore

Categories

(Firefox :: Session Restore, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 53
Tracking Status
firefox53 --- fixed

People

(Reporter: dao, Assigned: fionn_mac, Mentored)

References

Details

(Keywords: good-first-bug, Whiteboard: [good first bug][lang=js])

Attachments

(1 file)

Since bug 658467 landed, the crop attribute doesn't do anything on tabs anymore, so we should stop setting it here:

https://dxr.mozilla.org/mozilla-central/rev/8103c612b79c2587ea4ca1b0a9f9f82db4b185b8/browser/components/sessionstore/SessionStore.jsm#856

(In reply to Dão Gottwald [:dao] from comment #0)
> Since bug 658467 landed, the crop attribute doesn't do anything on tabs
> anymore, so we should stop setting it here:
> 
> https://dxr.mozilla.org/mozilla-central/rev/
> 8103c612b79c2587ea4ca1b0a9f9f82db4b185b8/browser/components/sessionstore/
> SessionStore.jsm#856

Dear Sir,

I am new to the open source community, and I wish to start contributing to it.
I saw that this bug has been marked as a good first bug, so I thought I might start here.

From what I understand, all that needs to be done is to see where the crop attribute for a tab is being set (which I believe is at two places), and then remove those lines of code after verifying that they don't affect any other areas of code adversely.

Do I have the right idea? If not, then since the code linked here is large, could you please point me in the right direction about what is to be done, so that I am better able to understand the problem and 
then analyze the code accordingly? 

Thanks.
(In reply to Vedant Sareen from comment #1)
> From what I understand, all that needs to be done is to see where the crop
> attribute for a tab is being set (which I believe is at two places), and
> then remove those lines of code after verifying that they don't affect any
> other areas of code adversely.
> 
> Do I have the right idea?

Quite right!
(In reply to Dão Gottwald [:dao] from comment #2)
> Quite right!

May I then start working on it?
(In reply to Vedant Sareen from comment #3)
> (In reply to Dão Gottwald [:dao] from comment #2)
> > Quite right!
> 
> May I then start working on it?

Yep, go ahead and let me know if you have questions.
Apologies for the late response.

I have 
1. Configured the tools (Linux build prerequisites) 
2. Downloaded the Mozilla source code via Mercurial
3. Made the changes in the file 'SessionStore.jsm' (Deleted lines 856 and 859 as seen in the file attached in your initial comment)
4. Built Firefox by executing ./mach build
5. Tried testing the changes by executing ./mach mochitest. However, I stopped the test processes as it went on for 4 hours. I didn't notice any failed tests though.

Should I proceed with submitting the patch for review now?
You can run only Session Restore tests this way:

./mach mochitest browser/components/sessionstore/
(In reply to Dão Gottwald [:dao] from comment #6)
> You can run only Session Restore tests this way:
> 
> ./mach mochitest browser/components/sessionstore/

I did so now, and the build passed all the tests.
Please upload your patch then!
Comment on attachment 8819637 [details] [diff] [review]
Diff file displaying the changes made to SessionStore.jsm

Looks good, thanks!
Attachment #8819637 - Flags: review+
Assignee: nobody → vedant.sareen
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f6103077f0ab
Stop setting the crop attribute on tabs. r=dao
https://hg.mozilla.org/mozilla-central/rev/f6103077f0ab
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 53
You need to log in before you can comment on or make changes to this bug.