Closed Bug 1323143 Opened 8 years ago Closed 7 years ago

remove the reference of external images in previous frame when the render_backend produces a new frame


(Core :: Graphics: WebRender, defect, P3)

53 Branch



Tracking Status
firefox53 --- affected


(Reporter: jerry, Assigned: jerry)




In bug 1320320, we will have a flush and synchronization waiting before rendering. That can make sure WR will not use the texture which is sent in previous transaction.

This bug try to make WR to hold the textures until WR has a new frame. In other words, all textures used in previous frame will be released when a new frame is coming. Then, we could try to remove the synchronization code without the use-after-free problem for texture.
Pushed by
extend the ExternalImageHandler callback functions. r=kvark?
handle the releasing of external images in api.delete_image(). r=kvark?
show panic if we try to call update() for external image. r=kvark?
update WR binding for external image life-time updates. r=nical?
Closed: 8 years ago
Resolution: --- → FIXED
I think in general we should avoid making changes to gfx/webrender - we should make the changes upstream in webrender and then update our in-tree copy of webrender. Otherwise it becomes hard to pick up webrender updates.
I effectively backed this out in by resetting the tree.

We discussed this on IRC briefly and I'm not sure if we came to a proper conclusion, but I think that since the PR is actively being reviewed we should wait for that and try to land the patches on upstream webrender, and then update the in-tree webrender wholesale.
Resolution: FIXED → ---
You need to log in before you can comment on or make changes to this bug.